? ? ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
3 Oct 2020

Pull Request for Issue # .

Summary of Changes

Proof of Concept
There are many complaints of users who don't know how to add modifier classes for Blog Layouts.
This PR is a proof of concept where the main classes for the modifiers are added to the blog layout params.
I would like to have some feedback and if it is accepted can add it to featured.

Open questions are, for example:

  • Is it self explaining and helpful?
  • Do we need global params for that ?

Testing Instructions

You need several articles in a category.

Now make a menu item for a category blog. In the Tab Blog Layout There are two new selections: Default classes.

grafik
One for leading articles (the screenshot), the same for intro articles.

If the user selects "yes", the shown presents new input fields:

grafik
The same for intro articles

Select here what you want, play with different combinations and see what happens with your blog. For example this:

grafik

Actual result BEFORE applying this Pull Request

There is one input field for the classes of the leading articles and one for the intro articles.

Expected result AFTER applying this Pull Request

There is one input field for the classes of the leading articles and one for the intro articles.
There are input fields for default classes.

Documentation Changes Required

yes

avatar chmst chmst - open - 3 Oct 2020
avatar chmst chmst - change - 3 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Oct 2020
Category Administration Language & Strings Front End com_content
avatar chmst chmst - change - 3 Oct 2020
The description was changed
avatar chmst chmst - edited - 3 Oct 2020
avatar brianteeman
brianteeman - comment - 3 Oct 2020

Testing this right now as this functionality is essential - thanks

Do we need global params for that ?

yes definitely

avatar brianteeman
brianteeman - comment - 3 Oct 2020
  1. We really need to resolve the three column layout thing. This page in particular is impossible to navigate. I had to hack it to one column to understand.

  2. I would move the #leading article to be the first field
    image

  3. As above with #intro articles

  4. columns should not be hidden

  5. Blog Class Default Classes
    Is this just a label to expand the other fields? If it is then it should be a switcher not a select and needs a better title

This is AWESOME

avatar SharkyKZ
SharkyKZ - comment - 3 Oct 2020

These classes are specific to Cassiopeia and should not be hardcoded in com_content.

avatar chmst chmst - change - 4 Oct 2020
Labels Added: ? ?
avatar chmst
chmst - comment - 4 Oct 2020

@brianteeman changes made as suggested.

@SharkyKZ have you an idea how we could make this possible? Maybe a plugin in cassiopeia?

avatar brianteeman
brianteeman - comment - 4 Oct 2020

@chmst thanks. Will test further

Regarding @Sharkyz comment. I dont see this PR as any different to j3 and its use of bootstrap classes.

This PR is essential if we dont want to make it way too hard for users to upgrade successfully or to use existing functionality. Right now columns etc dont do anything so users think it is broken

avatar chmst
chmst - comment - 4 Oct 2020

I understand that this is specific for cassiopeia. But it is hard to make a strict separation between core and template. Also the difference of leading items and blog items can be seen as template specific, or the intro images vs. fulltext images.
The changes in this PR are rather compact and they don't introduce dependencies so I think that it is an advantage for acceptance.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30910.

avatar ceford
ceford - comment - 4 Oct 2020

On this patch: my intro image came out very small, about the same size as a capital M. The other images were OK. To me it seems crazy that the 1/n column layout for Leading and Intro articles is not available by default. I remembered it from somewhere (J3?) and spent ages looking for it.

screen shot 2020-10-04 at 13 22 20


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30910.

avatar ceford
ceford - comment - 4 Oct 2020

I should have said also: I think the images are in the wrong place! I would float the image left or right of the text and add some padding.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30910.

avatar ChristineWk
ChristineWk - comment - 4 Oct 2020

Maybe I missed something?
screen shot 2020-10-04 at 20 59 30

Can't find Boxed Layout for columns and don't know what the Default Classes are. Sorry.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30910.

avatar ReLater
ReLater - comment - 5 Oct 2020

I don't know if it's of interest for this pr and Joomla 4 but as far as I know the CSS based "masonry" layouts (cards) have been removed from Bootytrap 5 for good reasons ("strange ordering and things"). One should not expect that it has a future for coming templates.
twbs/bootstrap#28922

avatar chmst
chmst - comment - 5 Oct 2020

Thank you all for testing and your meaning. We are working on a better solution in cassiopiea. I cles this for now.

avatar ChristineWk
ChristineWk - comment - 5 Oct 2020

@gostn Thank you for your image. It's clear now. It belongs to "Fields are expanded".

avatar chmst chmst - change - 5 Oct 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-10-05 20:50:47
Closed_By chmst
avatar chmst chmst - close - 5 Oct 2020
avatar chmst
chmst - comment - 26 Nov 2020

Re-Opening this as it can resolve the release blocker #27478
Needs calculationg the ordering number in blog layout.

vertical-blog

avatar chmst chmst - change - 26 Nov 2020
Status Closed New
Closed_Date 2020-10-05 20:50:47
Closed_By chmst
avatar chmst chmst - change - 26 Nov 2020
Status New Pending
avatar chmst chmst - reopen - 26 Nov 2020
avatar chmst chmst - change - 26 Nov 2020
Title
Add default classes to blog layouts
Add vertical ordering to blog layouts
avatar chmst chmst - edited - 26 Nov 2020
avatar brianteeman
brianteeman - comment - 27 Nov 2020

Is vertical ordering the same as the J3 option Multi Column Ordering?
image

If it is then can you rename it here.

avatar ChristineWk ChristineWk - test_item - 27 Nov 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 27 Nov 2020

I have tested this item successfully on dde1662


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30910.

avatar gostn gostn - test_item - 28 Nov 2020 - Tested successfully
avatar gostn
gostn - comment - 28 Nov 2020

I have tested this item successfully on dde1662


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30910.

avatar Harmageddon
Harmageddon - comment - 28 Nov 2020

Should the vertical ordering parameter have any effect yet? Because I don't see any, and I can't find where the parameter is being used in the view.

(Edit: Didn't want to pressure here, as the PR is still a draft. I was just wondering, but assume it's not yet implemented. ;-) )

avatar gostn
gostn - comment - 1 Dec 2020

who care on a draft having 2 successfully test

avatar richard67
richard67 - comment - 1 Dec 2020

@gostn It's the author who decides if a PR is draft or not.

avatar gostn
gostn - comment - 1 Dec 2020

@chmst what now, test are wastet time?

avatar HLeithner
HLeithner - comment - 1 Dec 2020

@gostn testing a draft may makes sense but mainly for discussion. If the PR didn't get changed the tests are still valid.

avatar gostn
gostn - comment - 1 Dec 2020

@HLeithner thanks for information not like #30716 (comment) by @richard67

avatar chmst chmst - change - 1 Dec 2020
Labels Added: ?
avatar chmst
chmst - comment - 1 Dec 2020

As it is easier for migration I have restored the two params from J3 for ordering down and number of columns. If a user chooses the order down, the input in blog class is ignored and the into items are displaed in columns.

avatar ChristineWk
ChristineWk - comment - 1 Dec 2020

When using this:

screen shot 2020-12-01 at 19 13 56
it looks OK.

When using this:
screen shot 2020-12-01 at 19 14 36

Frontend:
Notice: Undefined variable: numCols in /home/xyz/components/com_content/tmpl/category/blog.php on line 102 Notice: Undefined variable: numCols in /home/xyz/components/com_content/tmpl/category/blog.php on line 102


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30910.
avatar chmst
chmst - comment - 1 Dec 2020

Thank you @ChristineWk, fixed

avatar brianteeman
brianteeman - comment - 1 Dec 2020

Instead of Ordering option down can you use the J3 terminology

#30910 (comment)

avatar chmst
chmst - comment - 1 Dec 2020

@brianteeman I think, it is not quite the same because this ordering is ONLY for vertical ordering (down). He cannot choose fixed number of columns ad ordering "across" as before, this is made via modifier classes.

This solution is not really good, but at least enables a migration from J3 to j4.

An open question is: Is this option for leading articles and intro-articles? At the moment it is for intro-articles only.

avatar ChristineWk
ChristineWk - comment - 1 Dec 2020

@chmst Thank you. Notice is fixed.

avatar Harmageddon
Harmageddon - comment - 2 Dec 2020

Hmm, it kind of works for me, but now the value of "Blog Class (Intro Articles)" is ignored completely when using vertical layout. I think that's not optimal either. Of course, we get a conflict if someone enters "columns-3" for the class and then vertical layout with 2 columns. But what if someone wants to use any other class for the intro articles?

avatar ChristineWk
ChristineWk - comment - 2 Dec 2020

@Harmageddon Thks for your investigation :-)

Hmm, it kind of works for me, but now the value of "Blog Class (Intro Articles)" is ignored completely when using vertical layout. I think that's not optimal either. Of course, we get a conflict if someone enters "columns-3" for the class and then vertical layout with 2 columns. But what if someone wants to use any other class for the intro articles?

Maybe it belongs to this?

If a user chooses the order down, the input in blog class is ignored and the into items are displaed in columns.

avatar Harmageddon
Harmageddon - comment - 2 Dec 2020

Maybe it belongs to this?

If a user chooses the order down, the input in blog class is ignored and the into items are displaed in columns.

Ah yes, thank you. Still, I think it's not optimal, because the blog class can be used for other things than just columns. Maybe do a search/replace and remove the "columns-X" part in this case? In any case, this behaviour should be documented somewhere, because users will wonder why their input is ignored.

avatar Harmageddon
Harmageddon - comment - 2 Dec 2020

I'm trying to tackle this problem from a different angle, by providing an update script that converts the old column parameters to the according CSS classes. PR should be ready tomorrow or friday. ;-)

avatar paritshivani paritshivani - test_item - 5 Dec 2020 - Tested unsuccessfully
avatar paritshivani paritshivani - test_item - 5 Dec 2020 - Tested unsuccessfully
avatar paritshivani
paritshivani - comment - 5 Dec 2020

I have tested this item ? unsuccessfully on 39cbad4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30910.

avatar paritshivani
paritshivani - comment - 5 Dec 2020

I have tested this item ? unsuccessfully on 39cbad4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30910.

avatar ChristineWk
ChristineWk - comment - 5 Dec 2020

Vertical and horizontal arrangement look OK with me. But I don't know if this is enough for this PR. See also comments & new PR.

Vertical:
screen shot 2020-12-05 at 12 02 33

Horizontal:
screen shot 2020-12-05 at 12 02 54


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30910.

avatar Tejashrimajage Tejashrimajage - test_item - 5 Dec 2020 - Tested unsuccessfully
avatar Tejashrimajage
Tejashrimajage - comment - 5 Dec 2020

I have tested this item ? unsuccessfully on 39cbad4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30910.

avatar chmst
chmst - comment - 26 Dec 2020

Closing this in favour to #31570

avatar chmst chmst - change - 26 Dec 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-12-26 12:47:46
Closed_By chmst
avatar chmst chmst - close - 26 Dec 2020
avatar chmst chmst - change - 8 Feb 2021
Status Closed New
Closed_Date 2020-12-26 12:47:46
Closed_By chmst
avatar chmst chmst - change - 8 Feb 2021
Status New Pending
avatar chmst chmst - reopen - 8 Feb 2021
avatar chmst
chmst - comment - 8 Feb 2021

Reopening as a possible solution for issue #32012 - must be reviewed.

This solution could be better for users especially if the three-columns layout is set back and the blocks for intro and blog fields can be separated clearly.

avatar richard67
richard67 - comment - 8 Feb 2021

@chmst Will this still work now as #31570 has been merged?

avatar chmst
chmst - comment - 8 Feb 2021

I think yes. But as it must be reviewed.We have enough to do, so I close again and we can think again this in one of the following versions.

avatar chmst chmst - change - 8 Feb 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-02-08 21:10:50
Closed_By chmst
avatar chmst chmst - close - 8 Feb 2021
avatar Harmageddon
Harmageddon - comment - 8 Feb 2021

Hmm... #31570 converts the column parameters into CSS classes. If we want to re-introduce column parameters or some other sort of display parameters, it might be better to revert it, because the information about columns will be "lost" on upgraded sites (not lost, but transferred to the column-X class).
For new sites, #31570 doesn't change anything. But for sites that are updated from 3.x to 4.0, I think it would be better to make the decision now, whether to go only with CSS classes or with more sophisticated parameters.

Add a Comment

Login with GitHub to post a comment