User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Proof of Concept
There are many complaints of users who don't know how to add modifier classes for Blog Layouts.
This PR is a proof of concept where the main classes for the modifiers are added to the blog layout params.
I would like to have some feedback and if it is accepted can add it to featured.
Open questions are, for example:
You need several articles in a category.
Now make a menu item for a category blog. In the Tab Blog Layout There are two new selections: Default classes.
One for leading articles (the screenshot), the same for intro articles.
If the user selects "yes", the shown presents new input fields:
Select here what you want, play with different combinations and see what happens with your blog. For example this:
There is one input field for the classes of the leading articles and one for the intro articles.
There is one input field for the classes of the leading articles and one for the intro articles.
There are input fields for default classes.
yes
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Language & Strings Front End com_content |
We really need to resolve the three column layout thing. This page in particular is impossible to navigate. I had to hack it to one column to understand.
As above with #intro articles
Blog Class Default Classes
Is this just a label to expand the other fields? If it is then it should be a switcher not a select and needs a better title
This is AWESOME
These classes are specific to Cassiopeia and should not be hardcoded in com_content
.
Labels |
Added:
?
?
|
@brianteeman changes made as suggested.
@SharkyKZ have you an idea how we could make this possible? Maybe a plugin in cassiopeia?
@chmst thanks. Will test further
Regarding @Sharkyz comment. I dont see this PR as any different to j3 and its use of bootstrap classes.
This PR is essential if we dont want to make it way too hard for users to upgrade successfully or to use existing functionality. Right now columns etc dont do anything so users think it is broken
I understand that this is specific for cassiopeia. But it is hard to make a strict separation between core and template. Also the difference of leading items and blog items can be seen as template specific, or the intro images vs. fulltext images.
The changes in this PR are rather compact and they don't introduce dependencies so I think that it is an advantage for acceptance.
On this patch: my intro image came out very small, about the same size as a capital M. The other images were OK. To me it seems crazy that the 1/n column layout for Leading and Intro articles is not available by default. I remembered it from somewhere (J3?) and spent ages looking for it.
I should have said also: I think the images are in the wrong place! I would float the image left or right of the text and add some padding.
Can't find Boxed Layout for columns and don't know what the Default Classes are. Sorry.
I don't know if it's of interest for this pr and Joomla 4 but as far as I know the CSS based "masonry" layouts (cards) have been removed from Bootytrap 5 for good reasons ("strange ordering and things"). One should not expect that it has a future for coming templates.
twbs/bootstrap#28922
Thank you all for testing and your meaning. We are working on a better solution in cassiopiea. I cles this for now.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-05 20:50:47 |
Closed_By | ⇒ | chmst |
Status | Closed | ⇒ | New |
Closed_Date | 2020-10-05 20:50:47 | ⇒ | |
Closed_By | chmst | ⇒ |
Status | New | ⇒ | Pending |
Title |
|
I have tested this item
I have tested this item
Should the vertical ordering parameter have any effect yet? Because I don't see any, and I can't find where the parameter is being used in the view.
(Edit: Didn't want to pressure here, as the PR is still a draft. I was just wondering, but assume it's not yet implemented. ;-) )
who care on a draft having 2 successfully test
@HLeithner thanks for information not like #30716 (comment) by @richard67
Labels |
Added:
?
|
As it is easier for migration I have restored the two params from J3 for ordering down and number of columns. If a user chooses the order down, the input in blog class is ignored and the into items are displaed in columns.
When using this:
Frontend:
Notice: Undefined variable: numCols in /home/xyz/components/com_content/tmpl/category/blog.php on line 102 Notice: Undefined variable: numCols in /home/xyz/components/com_content/tmpl/category/blog.php on line 102
Thank you @ChristineWk, fixed
Instead of Ordering option down can you use the J3 terminology
@brianteeman I think, it is not quite the same because this ordering is ONLY for vertical ordering (down). He cannot choose fixed number of columns ad ordering "across" as before, this is made via modifier classes.
This solution is not really good, but at least enables a migration from J3 to j4.
An open question is: Is this option for leading articles and intro-articles? At the moment it is for intro-articles only.
Hmm, it kind of works for me, but now the value of "Blog Class (Intro Articles)" is ignored completely when using vertical layout. I think that's not optimal either. Of course, we get a conflict if someone enters "columns-3" for the class and then vertical layout with 2 columns. But what if someone wants to use any other class for the intro articles?
@Harmageddon Thks for your investigation :-)
Hmm, it kind of works for me, but now the value of "Blog Class (Intro Articles)" is ignored completely when using vertical layout. I think that's not optimal either. Of course, we get a conflict if someone enters "columns-3" for the class and then vertical layout with 2 columns. But what if someone wants to use any other class for the intro articles?
Maybe it belongs to this?
If a user chooses the order down, the input in blog class is ignored and the into items are displaed in columns.
Maybe it belongs to this?
If a user chooses the order down, the input in blog class is ignored and the into items are displaed in columns.
Ah yes, thank you. Still, I think it's not optimal, because the blog class can be used for other things than just columns. Maybe do a search/replace and remove the "columns-X" part in this case? In any case, this behaviour should be documented somewhere, because users will wonder why their input is ignored.
I'm trying to tackle this problem from a different angle, by providing an update script that converts the old column parameters to the according CSS classes. PR should be ready tomorrow or friday. ;-)
I have tested this item
I have tested this item
Vertical and horizontal arrangement look OK with me. But I don't know if this is enough for this PR. See also comments & new PR.
I have tested this item
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-26 12:47:46 |
Closed_By | ⇒ | chmst |
Status | Closed | ⇒ | New |
Closed_Date | 2020-12-26 12:47:46 | ⇒ | |
Closed_By | chmst | ⇒ |
Status | New | ⇒ | Pending |
I think yes. But as it must be reviewed.We have enough to do, so I close again and we can think again this in one of the following versions.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-08 21:10:50 |
Closed_By | ⇒ | chmst |
Hmm... #31570 converts the column parameters into CSS classes. If we want to re-introduce column parameters or some other sort of display parameters, it might be better to revert it, because the information about columns will be "lost" on upgraded sites (not lost, but transferred to the column-X class).
For new sites, #31570 doesn't change anything. But for sites that are updated from 3.x to 4.0, I think it would be better to make the decision now, whether to go only with CSS classes or with more sophisticated parameters.
Testing this right now as this functionality is essential - thanks
yes definitely