? ? Success

User tests: Successful: Unsuccessful:

avatar alikon
alikon
4 Oct 2020

Pull Request for Issue #30860 .

Summary of Changes

remove field spacer

Testing Instructions

see #30860

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

Screenshot from 2020-10-04 09-44-04

avatar alikon alikon - open - 4 Oct 2020
avatar alikon alikon - change - 4 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Oct 2020
Category Front End com_content
avatar gostn gostn - test_item - 4 Oct 2020 - Tested successfully
avatar brianteeman
brianteeman - comment - 4 Oct 2020

Please do not commit this until a decision is made about keeping the 3 column layout or not.

avatar alikon
alikon - comment - 4 Oct 2020

did you mean this one #29706 ?

avatar brianteeman
brianteeman - comment - 4 Oct 2020

yes - but I am sure there are other issues about this as well. The three columns looks nice but its not usable. And when you go back to the single column then a spacer like the one in this PR can be useful

avatar ceford ceford - test_item - 5 Oct 2020 - Tested successfully
avatar ceford
ceford - comment - 5 Oct 2020

I have tested this item successfully on e681c19

The PR does what it says. But even if present what does the spacer mean? On a 768 pixel wide screen the form comes out in two columns that is wider than the screen. The one column layout is too wide for a 375 pixel wide screen. I think the layout needs some work and the spacer does not seem to be of any significance to the end user.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30911.

avatar ChrisHoefliger
ChrisHoefliger - comment - 17 Oct 2020

Tested successfully

avatar wilsonge wilsonge - change - 17 Oct 2020
Status Pending Ready to Commit
avatar wilsonge
wilsonge - comment - 17 Oct 2020

RTC - But please DO NOT merge maintainers yet until a decision is made on 3 columns layouts in #29706 per @brianteeman 's comment


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30911.

avatar blueforce blueforce - test_item - 17 Oct 2020 - Tested successfully
avatar blueforce
blueforce - comment - 17 Oct 2020

I have tested this item successfully on e681c19

test ok, soved
OS: Mac OSX, Chrome 86.0.42.xx


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30911.

avatar richard67 richard67 - change - 1 Nov 2020
Labels Added: Conflicting Files
avatar richard67
richard67 - comment - 1 Nov 2020

@alikon I've allowed myself to fix the conflict for you.

avatar richard67
richard67 - comment - 1 Nov 2020

RTC - But please DO NOT merge maintainers yet until a decision is made on 3 columns layouts in #29706 per @brianteeman 's comment

The above comment by @wilsonge is still valid, so please hold on with merging. Maybe we need a new "On Hold" label?

avatar snehaM26 snehaM26 - test_item - 7 Nov 2020 - Tested unsuccessfully
avatar snehaM26
snehaM26 - comment - 7 Nov 2020

I have tested this item ? unsuccessfully on 5ac7472

I have tested this item.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30911.

avatar ashvini77 ashvini77 - test_item - 7 Nov 2020 - Tested unsuccessfully
avatar ashvini77
ashvini77 - comment - 7 Nov 2020

I have tested this item ? unsuccessfully on 5ac7472

Still, it's showing the field space


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30911.

avatar gostn gostn - test_item - 10 Nov 2020 - Not tested
avatar alikon alikon - change - 11 Nov 2020
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2020-11-11 13:43:25
Closed_By alikon
Labels Removed: Conflicting Files
avatar alikon alikon - close - 11 Nov 2020

Add a Comment

Login with GitHub to post a comment