? ? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
3 Oct 2020

Pull Request for Issue #30896

Summary of Changes

Add dependancy so that generic Ajax error messages are translated.

Testing Instructions

see #30896

Actual result BEFORE applying this Pull Request

error is untranslated JLIB_JS_AJAX_ERROR_OTHER

Expected result AFTER applying this Pull Request

94988693-70fbf000-056f-11eb-878a-f5aeb8af77f7

Documentation Changes Required

None

@infograf768

avatar PhilETaylor PhilETaylor - open - 3 Oct 2020
avatar PhilETaylor PhilETaylor - change - 3 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Oct 2020
Category Administration Templates (admin)
avatar infograf768 infograf768 - test_item - 3 Oct 2020 - Tested successfully
avatar infograf768
infograf768 - comment - 3 Oct 2020

I have tested this item successfully on d6b66ca


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30909.

avatar brianteeman
brianteeman - comment - 3 Oct 2020

Surely this was supposed to be handled in the js here

avatar PhilETaylor
PhilETaylor - comment - 3 Oct 2020

But that JS requires the translation strings to be present before it can use them... and this translated string was not in the page to be used - same as JGLOBAL_WARNCOOKIES

 "joomla.jtext": {
            "JSHOWPASSWORD": "Show Password",
            "JHIDEPASSWORD": "Hide Password",
            "ERROR": "Error",
            "WARNING": "Warning",
            "NOTICE": "Notice",
            "MESSAGE": "Message",
            "JGLOBAL_WARNCOOKIES": "Warning! Cookies must be enabled to access the Administrator Backend.",
            "JLIB_JS_AJAX_ERROR_OTHER": "An error has occurred while fetching the JSON data: HTTP %s status code.",
            "JCLOSE": "Close",
            "JOK": "OK",
            "JOPEN": "Open",
            "JLIB_FORM_CONTAINS_INVALID_FIELDS": "The form cannot be submitted as it's missing required data. <br> Please correct the marked fields and try again.",
            "JLIB_FORM_FIELD_REQUIRED_VALUE": "Please fill in this field",
            "JLIB_FORM_FIELD_REQUIRED_CHECK": "One of the options must be selected",
            "JLIB_FORM_FIELD_INVALID_VALUE": "This value is not valid"
        },
avatar infograf768
infograf768 - comment - 3 Oct 2020

Restarted drone.

avatar ceford ceford - test_item - 4 Oct 2020 - Tested successfully
avatar ceford
ceford - comment - 4 Oct 2020

I have tested this item successfully on d6b66ca

I can confirm the error message is translated. But ... what does 'An error has occurred while fetching the JSON data: HTTP 0 status code.' actually mean to the user?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30909.

avatar infograf768 infograf768 - change - 4 Oct 2020
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 4 Oct 2020

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30909.

avatar zero-24 zero-24 - close - 4 Oct 2020
avatar zero-24 zero-24 - merge - 4 Oct 2020
avatar zero-24 zero-24 - change - 4 Oct 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-10-04 19:48:28
Closed_By zero-24
Labels Added: ? ? ?
avatar zero-24
zero-24 - comment - 4 Oct 2020

Merged thanks @PhilETaylor I have added the label and the tag so that should help you geting the shirt right?

avatar PhilETaylor
PhilETaylor - comment - 4 Oct 2020

Haha I was only (half) joking about the T-Shirt ?

Add a Comment

Login with GitHub to post a comment