[#30869] - [4.0] media manager remove xs
- Fixed in Code Base
- 30 Nov 2020
- Medium
- Build: 4.0-dev
- # 30869
- Diff
- brianteeman:yk15
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/drone/pr Build is passing Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
PR for #29332
Steps to reproduce the issue
Got to media manager of a folder
Make sure the information block is displayed by clickin on the i icon in the toolbar
use the zoom out button as far as you can zoom out
Hover over an image or folder
Expected result
nice display
Actual result
When image list zoomed out to maximum zoom there is not enough room for both squares
Summary of changes
This PR removes the smallest zoom level
Test instructions
Don't forget to run npm ci
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media NPM Change JavaScript |
| Labels |
Added:
NPM Resource Changed
?
|
||
| Category | Administration com_media NPM Change JavaScript | ⇒ | Administration com_media NPM Change JavaScript Unit Tests |
| Labels |
Added:
Conflicting Files
?
|
||
| Category | Administration com_media NPM Change JavaScript Unit Tests | ⇒ | Administration com_media NPM Change Unit Tests |
| Labels |
Removed:
Conflicting Files
|
||
| Category | Administration com_media NPM Change Unit Tests | ⇒ | Administration com_media NPM Change JavaScript Unit Tests |
Conflicts resolved
this pr is nothing to do with that pr for mobile views
Elimination of the smallest size helps a little. I was thinking that resizing might apply to images only, leaving folders a constant size. But to be honest the media manager layout is such a mess on small screens I think it would be best to sort that out before applying this PR.
This is a worst case example:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30869.
I have tested this item
I installed the PR and the features works without any problems.
While doing some tests, I saw that there is always overlap between the buttons. Is it possible to stop a bit earlier?
A zoom level I think is enough.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30869.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30869.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30869.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-30 14:41:10 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
Removed: ? |
||
Thanks!
Thank you
I have tested this item✅ successfully on 70287ed
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30869.