I'd like to get rid of the Number!

I'd like to get rid of the Number!

Me too, if it is BC.

There is no b/c issue

Tested with success. If you remove the number column, I'll re-test.

There is no b/c issue

@brianteeman
Do you mean I can get rid of that column?

Any idea about this very specific <tr>
<tr class="<?php echo ($i % 2) ? 'odd' : 'even'; ?>" itemscope itemtype="https://schema.org/Person">

Should I replace it with the same stuff we have in the category list?

						<?php if ($this->items[$i]->published == 0) : ?>
							<tr class="system-unpublished featured-list-row<?php echo $i % 2; ?>">
						<?php else : ?>
							<tr class="featured-list-row<?php echo $i % 2; ?>" >
						<?php endif; ?>

1. yes - its just a display you are not removing data

2. that css is/was to create "stripes"

@chmst @brianteeman
please test again
also moved Unpublished badge below contact title (log to see)

The list is a big improvement.

For the filter, I have some doubts.

• The form is only the filter, not the whole list
• Search field and list limit are no fieldset, they don't belong together
• The clear button does not clear the input.

The clear button works if

Follow up on #30813 and #30859
Warning: these 2 PR have to be present in your test site to test the Clear button.

npm ci has to be applied

@chmst
I replied to your concerns above, I guess.

The point was that it's not a fiedset

On Sat, 3 Oct 2020, 15:44 infograf768, notifications@github.com wrote:

@infograf768 commented on this pull request.

In components/com_contact/tmpl/featured/default_items.php
#30868 (comment):

<form action="<?php echo htmlspecialchars(Uri::getInstance()->toString()); ?>" method="post" name="adminForm" id="adminForm">

• <?php if ($this->params->get('filter_field') || $this->params->get('show_pagination_limit')) : ?>
  <fieldset class="com-contact-featured__filters filters">
  

Please look at similar code for
components/com_content/tmpl/category/default_articles.php

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#30868 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJ4P4OKGAWNTD2WLT4DYN3SI42DRANCNFSM4SBRDOUQ
.

The point was that it's not a fiedset

Then you may have to change the code for articles in 3.x and for articles and contacts lists in 4.0-dev, which you tested OK

https://github.com/joomla/joomla-cms/blob/staging/components/com_content/views/category/tmpl/default_articles.php#L67-L104

I have no opinion on if it should be a fieldset or not. I was merely explaining why @chmst said that you should not have the legend.

Animated gif concerning the Clear filter.

I obviously can take off the part concerning fieldset, here and in List Contacts in a Category, if desired.

I am asking @zwiastunsw to please help on this decision as we have only one input (the searchfield)
One aspect is sure: if we keep the fieldset, it must have a legend.

After discussing with @chmst and @zwiastunsw fieldset is not necessary.
Reworked the tmpl.

Please test.

Note

Another PR will follow for contacts list and articles list.

I have tested this item ✅ successfully on 510dc5f

I have tested this item ✅ successfully on 510dc5f

RTC

title removed as requested.
I guess no need to test again.

Thanks

Similar PR for articles
#30981