Feeling Lucky
?
[#30741] - [4.0] Correct some spelling mistakes in comments
- Closed
- 23 Sep 2020
- Medium
- Build: staging
- # 30741
Problem identified
I was looking at PR #30724 where "Dummymethod" has been corrected to "Dummy method" but I noticed that "fullfill" in the same line is incorrect. It should either be "fulfil" (English UK) or "fulfill" (English US).
Additionally, in the Joomla copyright information the word "License" has the US spelling. I was under the impression that Joomla was using UK English for its spelling, so "License" should be "Licence".
This applies to both front and back ends.
Proposed solution
- Change "fullfill" to "fulfil" wherever it occurs
- Change "License" to "License" wherever it occurs
Open questions
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-23 10:39:18 |
| Closed_By | ⇒ | richard67 |
richard67
- comment
- 23 Sep 2020
@Scrabble96 Additional info: Of course there are much more occurrences of fulfill than fixed by PR #30742 on an installation, but all these belong to external libraries, and in J4 we don't have them in our sources, so the PR covers all we can do.
Scrabble96
- comment
- 23 Sep 2020
Thank you both @brianteeman and @richard67
oops my mistake on fulfil I will fix that now
I dont want to correct the spelling of License as there are external software tools that all assume the american spelling