? NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar pdkpavankumar
pdkpavankumar
23 Sep 2020

Pull Request for Issue # #30715.

Summary of Changes

fixing hardcoded value to variable value for cassiopea table css

Testing Instructions
go to any article in front end and edit (login as admin)
click on versions
inspect the table (table -> td)

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

table padding should take values from variables $table-cell-padding-sm rather than 8px hardcoded

Documentation Changes Required

NO

avatar pdkpavankumar pdkpavankumar - open - 23 Sep 2020
avatar pdkpavankumar pdkpavankumar - change - 23 Sep 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Sep 2020
Category Front End Templates (site) NPM Change
avatar pdkpavankumar pdkpavankumar - change - 23 Sep 2020
Labels Added: NPM Resource Changed ?
avatar pdkpavankumar pdkpavankumar - change - 23 Sep 2020
Title
Cassiopea table css
[4.0] Cassiopea table css
avatar pdkpavankumar pdkpavankumar - edited - 23 Sep 2020
avatar richard67
richard67 - comment - 23 Sep 2020

Please provide some testing instructions.

avatar pdkpavankumar pdkpavankumar - change - 23 Sep 2020
The description was changed
avatar pdkpavankumar pdkpavankumar - edited - 23 Sep 2020
avatar pdkpavankumar pdkpavankumar - change - 23 Sep 2020
The description was changed
avatar pdkpavankumar pdkpavankumar - edited - 23 Sep 2020
avatar pdkpavankumar pdkpavankumar - change - 23 Sep 2020
The description was changed
avatar pdkpavankumar pdkpavankumar - edited - 23 Sep 2020
avatar pdkpavankumar pdkpavankumar - change - 23 Sep 2020
The description was changed
avatar pdkpavankumar pdkpavankumar - edited - 23 Sep 2020
avatar pdkpavankumar
pdkpavankumar - comment - 23 Sep 2020

Please provide some testing instructions.

added @richard67 its more of css update

avatar richard67
richard67 - comment - 23 Sep 2020

Thanks.

avatar SharkyKZ
SharkyKZ - comment - 23 Sep 2020

Remove padding from this file completely.

avatar pdkpavankumar pdkpavankumar - change - 23 Sep 2020
Labels Added: ?
avatar Quy Quy - test_item - 23 Sep 2020 - Tested successfully
avatar Quy
Quy - comment - 23 Sep 2020

I have tested this item successfully on ed3612b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30740.

avatar jwaisner jwaisner - test_item - 28 Sep 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 28 Sep 2020

I have tested this item successfully on ed3612b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30740.

avatar jwaisner jwaisner - change - 28 Sep 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 28 Sep 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30740.

avatar infograf768 infograf768 - close - 29 Sep 2020
avatar infograf768 infograf768 - merge - 29 Sep 2020
avatar infograf768 infograf768 - change - 29 Sep 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-09-29 06:31:13
Closed_By infograf768
Labels Added: ?
avatar infograf768
infograf768 - comment - 29 Sep 2020

tks.

Add a Comment

Login with GitHub to post a comment