[#30739] - [4.0] Fancy selectbox fix
- Fixed in Code Base
- 26 Sep 2020
- Medium
- Build: 4.0-dev
- # 30739
- Diff
- pdkpavankumar:fancy-selectbox-fix
User tests: Successful: Unsuccessful:
Pull Request for Issue # #29846 .
Summary of Changes
css changes for x alignment in fancy select box
Testing Instructions
Article edit page
Category select box
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
NO
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
| Title |
|
||||||
Not sure it should be done through .choices__list--single {
Imho, it should be done via
.choices[data-type*="select-one"] {
.choices__button_joomla {
Please look at the cassiopea scss that I just modified (margin values would be different and atum variables should be used)
https://github.com/joomla/joomla-cms/blob/4.0-dev/templates/cassiopeia/scss/vendor/choicesjs/choices.scss#L47-L92
It implies refactoring atum choices.scss. Just compare both files.
Persian language
@infograf768 thanks for the review comment, updated the PR accordingly.
Sadly, it is still an issue on Safari for MacOS.
Backend is slightly different from frontend
Margin-right for LTR: please modify to 50px instead of 45px
Margin-left for RTL: same
Safari screenshots are fine (as other browsers):
To test this patch correctly, make sure all caches are cleared. Quit the browser and launch again after npm ci.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30739.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30739.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30739.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-26 06:46:48 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thanks
Persian language
Before PR:
After PR:
