? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
23 Sep 2020

Summary of Changes

Fixes showon not working.

Testing Instructions

Edit user profile in frontend.

Actual result BEFORE applying this Pull Request

Showon for Events to Email field doesn't work. It's always shown.

Expected result AFTER applying this Pull Request

Events to Email is only shown when Email Notifications is enabled.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 23 Sep 2020
avatar SharkyKZ SharkyKZ - change - 23 Sep 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Sep 2020
Category Front End com_users
avatar Formatio-hippocampi Formatio-hippocampi - test_item - 23 Sep 2020 - Tested successfully
avatar Formatio-hippocampi
Formatio-hippocampi - comment - 23 Sep 2020

I have tested this item successfully on 1962d28


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30738.

avatar Formatio-hippocampi
Formatio-hippocampi - comment - 23 Sep 2020

In View Events to Email always shown:
Screen Shot 2020-09-23 at 10 06 17

avatar SharkyKZ
SharkyKZ - comment - 23 Sep 2020

That's a different issue.

avatar Formatio-hippocampi
Formatio-hippocampi - comment - 23 Sep 2020

That's a different issue.

i know. so you like a new issue?

avatar SharkyKZ
SharkyKZ - comment - 23 Sep 2020

I don't really think this is an issue. I wouldn't hide item data like that. I'm not a fan of hiding fields in forms either but that's what we do everywhere so ?‍♂️ .

avatar joomlacorner joomlacorner - test_item - 23 Sep 2020 - Tested successfully
avatar joomlacorner
joomlacorner - comment - 23 Sep 2020

I have tested this item successfully on 1962d28

work as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30738.

avatar joomlacorner
joomlacorner - comment - 23 Sep 2020

after apply this patch. it's worked.

screen shot 2020-09-23 at 10 36 20


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30738.

avatar alikon alikon - change - 23 Sep 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 23 Sep 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30738.

avatar richard67 richard67 - change - 23 Sep 2020
Labels Added: ? ?
avatar wilsonge wilsonge - change - 23 Sep 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-09-23 19:53:21
Closed_By wilsonge
Labels
avatar wilsonge wilsonge - close - 23 Sep 2020
avatar wilsonge wilsonge - merge - 23 Sep 2020
avatar wilsonge
wilsonge - comment - 23 Sep 2020

Thanks!

Add a Comment

Login with GitHub to post a comment