? ? Pending

User tests: Successful: Unsuccessful:

avatar hans2103
hans2103
23 Sep 2020

Pull Request for Issue # .

Summary of Changes

This PR removes obsolete HTML code. I can see no need for the extra HTML provided.
And... it will benefit the work on the styling of improved Cassiopeia

Testing Instructions

  • Joomla 4 install
  • Login in and go to /index.php/component/config?view=config
  • Apply the path (no npm required)
  • Refresh the page and even without the wrapping divs, the result is the same.

And the result needs some improvement. Spacing between fieldsets. Cassiopeia Team is working on it.

Actual result BEFORE applying this Pull Request

joomla4 test_index php_component_config_view=config

Expected result AFTER applying this Pull Request

joomla4 test_index php_component_config_view=config (1)

Documentation Changes Required

avatar hans2103 hans2103 - open - 23 Sep 2020
avatar hans2103 hans2103 - change - 23 Sep 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Sep 2020
Category Front End com_config
avatar hans2103 hans2103 - change - 23 Sep 2020
Title
Remove obsolete html code
[4.0] Remove obsolete html code
avatar hans2103 hans2103 - edited - 23 Sep 2020
avatar Formatio-hippocampi Formatio-hippocampi - test_item - 23 Sep 2020 - Tested successfully
avatar Formatio-hippocampi
Formatio-hippocampi - comment - 23 Sep 2020

I have tested this item successfully on 8fe3e8c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30737.

avatar sandewt sandewt - test_item - 23 Sep 2020 - Tested successfully
avatar sandewt
sandewt - comment - 23 Sep 2020

I have tested this item successfully on 8fe3e8c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30737.

avatar sandewt
sandewt - comment - 23 Sep 2020

@hans2103 you have deleted class="col-md-12">

What makes this code obsolate?
There are other templates with this html code. Is there also obsolate html code?

[EDIT]


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30737.
avatar richard67
richard67 - comment - 24 Sep 2020

What makes this code obsolate?
There are other templates with this html code. Is there also obsolate html code?

@hans2103 Could you answer that question?

avatar richard67
richard67 - comment - 24 Sep 2020

@sandewt I'm a bit confused now. You've tested with success but have doubt on removal of the bootstrap grid class. Is this PR good now or not in your opinion?

avatar chmst
chmst - comment - 24 Sep 2020

@sandewt mybe you are speaking about administrator layouts? They are pure bootstrap4. This is a frontend layout where we are working to become independent from any framework.

I have tested the changes successfully.

avatar richard67 richard67 - change - 24 Sep 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 24 Sep 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30737.

avatar richard67 richard67 - change - 24 Sep 2020
Labels Added: ? ?
avatar sandewt
sandewt - comment - 24 Sep 2020

@richard67 ,

I started from the expertise of @hans2103 ?
Afterwards I had asked the question before testing.

avatar sandewt
sandewt - comment - 24 Sep 2020

@chmst ,

Do not look too much behind it.
Searching on the core code (class="col-md-12") will yield various hits.
I would like an answer to my question for a better understanding.

avatar richard67
richard67 - comment - 24 Sep 2020

@sandewt I could see only a 3 php files outside the administrator area beside the onde handled by this PR here where it is used:

  • ./installation/tmpl/preinstall/default.php
  • ./components/com_config/tmpl/templates/default.php
  • ./components/com_config/tmpl/modules/default.php

The classed refer to bootstrap grid, and it might be that they are removed from these places, too.

@hans2103 Do you agree?

avatar hans2103
hans2103 - comment - 24 Sep 2020

@hans2103 you have deleted class="col-md-12">

What makes this code obsolate?
There are other templates with this html code. Is there also obsolate html code?

[EDIT]

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30737.

it depends and that shall have to be investigated per situation. But that is beyond the scope of this PR

avatar sandewt
sandewt - comment - 24 Sep 2020

I could see only a 3 php files outside the administrator area beside the onde handled by this PR here where it is used:

@richard67 Correct.

Addition:
The System - HTTP Headers file: ...\plugins\system\httpheaders\httpheaders.xml is located outside the administrator but is only visible there, also contains class="col-md-12" (probably nothing new).

avatar sandewt
sandewt - comment - 24 Sep 2020

it depends and that shall have to be investigated per situation. But that is beyond the scope of this PR

Then my test is actually worthless. ?

avatar richard67
richard67 - comment - 24 Sep 2020

@sandewt So what have you tested then? Have you tested as described, and it was successful, like you marked your test result? Or not? Shall I reset your test result?

avatar brianteeman
brianteeman - comment - 24 Sep 2020

This code was introduced in #19230

avatar sandewt
sandewt - comment - 24 Sep 2020

Shall I reset your test result?

@richard67 No worry. I followed the test instructions above exactly. And it was successful.

But experience teaches that sometimes you have to look a little further, hence my question to @hans2103. Or is that not the intention when testing? I have doubts now.

avatar hans2103
hans2103 - comment - 24 Sep 2020

This code was introduced in #19230

@brianteeman thank you for this reference to the origin of this addition.

As you can see at my screenshot and hopefully also on all of your installations the issue as described on #19230 does not appear after applying this PR.
When merged some simple css we are working on in joomla/cassiopeia ensures proper styling between the fieldset

avatar Quy Quy - change - 24 Sep 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-09-24 18:43:02
Closed_By Quy
Labels
avatar Quy Quy - close - 24 Sep 2020
avatar Quy Quy - merge - 24 Sep 2020
avatar Quy
Quy - comment - 24 Sep 2020

Thanks!

Add a Comment

Login with GitHub to post a comment