User tests: Successful: Unsuccessful:
Pull Request for Issue # .
This PR removes obsolete HTML code. I can see no need for the extra HTML provided.
And... it will benefit the work on the styling of improved Cassiopeia
npm
required)And the result needs some improvement. Spacing between fieldsets. Cassiopeia Team is working on it.
Status | New | ⇒ | Pending |
Category | ⇒ | Front End com_config |
Title |
|
I have tested this item
@hans2103 you have deleted class="col-md-12">
What makes this code obsolate?
There are other templates with this html code. Is there also obsolate html code?
[EDIT]
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
?
|
@sandewt I could see only a 3 php files outside the administrator area beside the onde handled by this PR here where it is used:
The classed refer to bootstrap grid, and it might be that they are removed from these places, too.
@hans2103 Do you agree?
@hans2103 you have deleted
class="col-md-12">
What makes this code obsolate?
There are other templates with this html code. Is there also obsolate html code?[EDIT]
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30737.
it depends and that shall have to be investigated per situation. But that is beyond the scope of this PR
I could see only a 3 php files outside the administrator area beside the onde handled by this PR here where it is used:
@richard67 Correct.
Addition:
The System - HTTP Headers file: ...\plugins\system\httpheaders\httpheaders.xml is located outside the administrator but is only visible there, also contains class="col-md-12"
(probably nothing new).
it depends and that shall have to be investigated per situation. But that is beyond the scope of this PR
Then my test is actually worthless.
Shall I reset your test result?
@richard67 No worry. I followed the test instructions above exactly. And it was successful.
But experience teaches that sometimes you have to look a little further, hence my question to @hans2103. Or is that not the intention when testing? I have doubts now.
This code was introduced in #19230
@brianteeman thank you for this reference to the origin of this addition.
As you can see at my screenshot and hopefully also on all of your installations the issue as described on #19230 does not appear after applying this PR.
When merged some simple css we are working on in joomla/cassiopeia ensures proper styling between the fieldset
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-24 18:43:02 |
Closed_By | ⇒ | Quy | |
Labels |
Thanks!
I have tested this item✅ successfully on 8fe3e8c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30737.