? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
23 Sep 2020

fix my own mistake the correct spelling is fulfil

Pull Request for Issue #30741

avatar brianteeman brianteeman - open - 23 Sep 2020
avatar brianteeman brianteeman - change - 23 Sep 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Sep 2020
Category Libraries
avatar brianteeman brianteeman - edited - 23 Sep 2020
avatar brianteeman brianteeman - change - 23 Sep 2020
The description was changed
avatar richard67 richard67 - test_item - 23 Sep 2020 - Tested successfully
avatar richard67
richard67 - comment - 23 Sep 2020

I have tested this item successfully on 0380595

Checked that this PR covers all occurrences of fulfill in comments in PHP files which we can change.

The lots of other places where it can be found belong to vendor libraries, so we shouldn't touch them. Silly me, ain't in the sources anyway on J4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30742.

avatar alikon alikon - test_item - 23 Sep 2020 - Tested successfully
avatar alikon
alikon - comment - 23 Sep 2020

I have tested this item successfully on 0380595

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30742.

avatar alikon alikon - change - 23 Sep 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 23 Sep 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30742.

avatar wilsonge wilsonge - close - 23 Sep 2020
avatar wilsonge wilsonge - merge - 23 Sep 2020
avatar wilsonge wilsonge - change - 23 Sep 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-09-23 19:50:06
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge
wilsonge - comment - 23 Sep 2020

Thanks!

avatar brianteeman
brianteeman - comment - 23 Sep 2020

thanks - but it was my mistake in the first place :(

Add a Comment

Login with GitHub to post a comment