[#30730] - [4.0] Fix saving images
- Fixed in Code Base
- 23 Sep 2020
- Medium
- Build: 4.0-dev
- # 30730
- Diff
- SharkyKZ:j4/fix/media-image-save
User tests: Successful: Unsuccessful:
Summary of Changes
Fixes saving images after editing in media manager.
Testing Instructions
node build.js --compile-js required.
Edit an article.
In editor click CMS Content -> Image.
Edit an image in the modal.
Click Save & Close.
Actual result BEFORE applying this Pull Request
Modified image is not saved and modules appear in the modal after redirect.
Expected result AFTER applying this Pull Request
Modified images is saved and your are redireceted back to media list without modules showing.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
I always get a correct success message when modifying image title and using Save.
I have no message when modifying image and saving.
If I modify image and Save and Close, the modified image is not yet displayed as it was modified. I have to close the modal and open it again to see the change.
These may be unrelated to this PR.
I have tested this item
Works as described.
Findings by @infograf768 could be fixed with another, future PR.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30730.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30730.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30730.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-23 07:01:20 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
Tks.
@SharkyKZ There are javascript lint errors: https://ci.joomla.org/joomla/joomla-cms/35601/1/23.