?
avatar mahagr
mahagr
22 Sep 2020

Steps to reproduce the issue

  • Run SQL command: UPDATE #__menus SET checked_out=0 WHERE client_id=0
  • Click on System > Maintenance > Global Check-in

Expected result

You should be able to check-in menu items.

Actual result

There are no tables with checked out items or there are no tables with checked out items that match your search.

You can restore your DB by: UPDATE #__menus SET checked_out=DEFAULT WHERE client_id=0

System information (as much as possible)

Joomla 4.0.0-beta4

Additional comments

If any of the tables, say #__menu, contains items saved with older Joomla 3.9 component, they may have items with check_out being 0. Unfortunately, a few Joomla models only check against user_id and NULL, meaning that the items may/will be semi-locked forever with no way to update them.

administrator/components/com_checkin/src/Model/CheckinModel.php should be changed to check against something else than >=0. In fact, I don't think that WHERE clause is needed at all.

avatar mahagr mahagr - open - 22 Sep 2020
avatar joomla-cms-bot joomla-cms-bot - change - 22 Sep 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 22 Sep 2020
avatar mahagr mahagr - change - 22 Sep 2020
Title
Global check-in does not clear check_out=0
[4.0] Global check-in does not clear check_out=0
avatar mahagr mahagr - edited - 22 Sep 2020
avatar richard67
richard67 - comment - 23 Sep 2020

@SharkyKZ Could you have a look on this issue?

avatar SharkyKZ
SharkyKZ - comment - 23 Sep 2020

We can check if checked_out column is nullable like we do with the date.

avatar richard67
richard67 - comment - 23 Sep 2020

We can check if checked_out column is nullable like we do with the date.

Sounds good. Do you wanna make a PR?

avatar SharkyKZ
SharkyKZ - comment - 23 Sep 2020

Please test PR #30747.

avatar SharkyKZ SharkyKZ - close - 23 Sep 2020
avatar SharkyKZ SharkyKZ - change - 23 Sep 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-09-23 13:41:07
Closed_By SharkyKZ

Add a Comment

Login with GitHub to post a comment