[#30676] - Correct checkin permissions
- Fixed in Code Base
- 21 Sep 2020
- Medium
- Build: staging
- # 30676
- Diff
- SharkyKZ:j3/fix/checkin-permissions
User tests: Successful: Unsuccessful:
Pull Request for Issue Reported on JSE https://joomla.stackexchange.com/questions/28479/what-permission-do-you-need-to-check-in-others-article-at-any-time.
Summary of Changes
In view layouts and in com_checkin we use core.manage permission check to determine whether users can perform a check in. But in the model we use core.admin check. This way the check in button appears enabled but check in fails. However, user with core.manage permissions in com_checkin can still check in items through com_checkin.
Testing Instructions
Create a user in Manager group.
Give Access Administrator Interface permissions in com_checkin to managers.
While still logged in as super user checkout an article.
Login to backend as manager.
Try to check in the article from article list and from com_checkin.
Actual result BEFORE applying this Pull Request
Checking in in article list fails but works in com_checkin.
Expected result AFTER applying this Pull Request
Checking in works in both places.
Documentation Changes Required
IDK.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
Better test with Manager group. Instructions updated.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30676.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30676.
| Labels |
Added:
?
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-21 10:02:13 |
| Closed_By | ⇒ | infograf768 | |
| Labels | |||
Tks
I have tested this item✅ successfully on 113aa62
First I couldn't reproduce the issue on a newly installed current staging.
The reason is that both the
Access Administrator InterfaceandConfigure ACL & Optionspermissions in com_checkin were already granted for the administrator group.After having revoked the
Configure ACL & Optionspermissions in com_checkin for administrators, everything worked as described.@SharkyKZ Maybe you should pimp the testing instructions to handle that.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30676.