[#30675] - Fix tabs not wrapping and trigger horizontal scrolling
- Fixed in Code Base
- 18 Sep 2020
- Medium
- Build: 4.0-dev
- # 30675
- Diff
- Ruud68:configurationtabs
User tests: Successful: Unsuccessful:
Pull Request for Issue #30667
Summary of Changes
Add flex wrap to enable wrap on tabs
Testing Instructions
- apply pr,
- npm run build:css
Actual result BEFORE applying this Pull Request
see issue #30667
Expected result AFTER applying this Pull Request
see issue #30667
Documentation Changes Required
nope
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
@chmst @wilsonge Could you test this PR with the laptops you have used for reproducing issue #28799 ? To me it seems other issues than the tabs, e.g. the width of the toolbar and header area either have been solved elsewhere meanwhile, or they are magically solved with this PR, too, or my 2 screens are not suitable to reproduce the other issues.
I have tested this item
Not sure if it is the best solution, but it is a solution which works, and for me it's ok.
Hoping for more opinions.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30675.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30675.
| Labels |
Added:
?
?
NPM Resource Changed
|
||
@richard67 thanks for testing and RTC :)
This is the default way bootstrap 4 implements tabs, see here: https://getbootstrap.com/docs/4.5/components/navs/#tabs
In any case it is better than before and resolves the issue with horizontal scrolling. So RTC is good for me.
I mean it's ugly as hell but it wraps. Which is more than it does now
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-18 20:50:42 |
| Closed_By | ⇒ | wilsonge | |
| Labels | |||
Thanks!
I have tested this item✅ successfully on 7778840
Joomla! 4.0.0-beta5-dev Development [ Mañana ] 15-September-2020 19:15 GMT
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30675.