NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar N6REJ
N6REJ
18 Sep 2020

Pull Request for Issue # .

Summary of Changes

Changes toolbar::title to use layout. This solves the issue of some 3rd party icons not rendering properly in title area.
bit of code cleanup.

Testing Instructions

install akeeba &/or JCE
check that icons display properly.
apply pr ( download prebuilt or run npm build:css )
verify icons still display properly.

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

image
image

Documentation Changes Required

avatar N6REJ N6REJ - open - 18 Sep 2020
avatar N6REJ N6REJ - change - 18 Sep 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Sep 2020
Category Layout
avatar ChristineWk ChristineWk - test_item - 18 Sep 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 18 Sep 2020

I have tested this item successfully on ae03c2b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30677.

avatar N6REJ N6REJ - change - 18 Sep 2020
Labels Added: ?
avatar ChristineWk ChristineWk - test_item - 18 Sep 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 18 Sep 2020

I have tested this item successfully on f76e305

2nd test (typo) via Code Review 4.0.0-beta5-dev


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30677.

avatar sandewt sandewt - test_item - 18 Sep 2020 - Tested successfully
avatar sandewt
sandewt - comment - 18 Sep 2020

I have tested this item successfully on f76e305

Joomla! 4.0.0-beta5-dev Development [ Mañana ] 15-September-2020 19:15 GMT

I have installed Abeeba (not JCE).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30677.
avatar brianteeman brianteeman - test_item - 19 Sep 2020 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 19 Sep 2020

I have tested this item ? unsuccessfully on d52f029


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30677.

avatar brianteeman
brianteeman - comment - 19 Sep 2020

Some icons are missing now
image

It's not broken dont try to fix it.!!

avatar sandewt
sandewt - comment - 19 Sep 2020

Some icons are missing now

Html before PR:

<span class="fas fa-puzzle-piece fields content-groups" aria-hidden="true"></span>

Html after PR:

<span class="icon-puzzle-piece fields content-groups" aria-hidden="true"></span>

And...

<span class="icon-puzzle-piece fields users-user-fields" aria-hidden="true"></span> (Users: Fields)

<span class="icon-puzzle-piece fields users-groups" aria-hidden="true"></span> (Users: Field Groups)

avatar joomla-cms-bot joomla-cms-bot - change - 19 Sep 2020
Category Layout Repository NPM Change Layout
avatar N6REJ
N6REJ - comment - 19 Sep 2020

@brianteeman @sandewt issue fixed. I choose to use scss & map it instead of adding it to layout as we are going to be moving as much as we can from layout to scss in the near future.
But that's an entirely different pr.
Although it renders icon-puzzle-piece it is infact fas fa-puzzle-piece.

avatar brianteeman
brianteeman - comment - 19 Sep 2020

no you have just moved the issue to somewhere else. each one of these icon change prs just creates more issues elsewhere. please stop, undo all this stuff and then we can all (yourself included) concentrate on real issues instead of creating new ones.

avatar N6REJ N6REJ - change - 20 Sep 2020
The description was changed
avatar N6REJ N6REJ - edited - 20 Sep 2020
avatar N6REJ
N6REJ - comment - 20 Sep 2020

no you have just moved the issue to somewhere else. each one of these icon change prs just creates more issues elsewhere. please stop, undo all this stuff and then we can all (yourself included) concentrate on real issues instead of creating new ones.

idk how you can justify that statement but your welcome to your opinion.

avatar brianteeman
brianteeman - comment - 20 Sep 2020

ITs simple really. Just count the number of PRs (open and closed) that have been created just to get back to the exact same situation that we had before you started the unnecessary change to not use "fa".

avatar N6REJ
N6REJ - comment - 20 Sep 2020

ITs simple really. Just count the number of PRs (open and closed) that have been created just to get back to the exact same situation that we had before you started the unnecessary change to not use "fa".

Where do you get the idea that i/we don't want to use FA? It's exactly the opposite issue!
if you mean the prefix "fa" then thats a valueless argument as there is no such VALID prefix in fa 5+.
valid prefix's are now FAS & FAB for the free icon family set. HOWEVER we're required to have the "icon-" icon family set work 100% at the same time. On top of that we're mandated to support unknown icon sets & have been encouraged to get as close to zero hard code as possible.
These are not easy to keep all at the same time.
Add to all that the fact that there are roughly 6 different ways to render an icon and you begin to get the most microscopic picture of what a task we truly face.

avatar brianteeman
brianteeman - comment - 20 Sep 2020

if you mean the prefix "fa" then thats a valueless argument as there is no such VALID prefix in fa 5+.
As I have said repeatedly before that is a false assumption

avatar N6REJ
N6REJ - comment - 21 Sep 2020

I give up.

avatar N6REJ N6REJ - change - 21 Sep 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-09-21 19:58:01
Closed_By N6REJ
Labels Added: NPM Resource Changed
avatar N6REJ N6REJ - close - 21 Sep 2020
avatar sandewt
sandewt - comment - 22 Sep 2020

Thanks all

Add a Comment

Login with GitHub to post a comment