User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Changes toolbar::title to use layout. This solves the issue of some 3rd party icons not rendering properly in title area.
bit of code cleanup.
install akeeba &/or JCE
check that icons display properly.
apply pr ( download prebuilt or run npm build:css )
verify icons still display properly.
Status | New | ⇒ | Pending |
Category | ⇒ | Layout |
Labels |
Added:
?
|
I have tested this item
2nd test (typo) via Code Review 4.0.0-beta5-dev
I have tested this item
Joomla! 4.0.0-beta5-dev Development [ Mañana ] 15-September-2020 19:15 GMT
I have installed Abeeba (not JCE).
I have tested this item
Some icons are missing now
Html before PR:
<span class="fas fa-puzzle-piece fields content-groups" aria-hidden="true"></span>
Html after PR:
<span class="icon-puzzle-piece fields content-groups" aria-hidden="true"></span>
And...
<span class="icon-puzzle-piece fields users-user-fields" aria-hidden="true"></span>
(Users: Fields)
<span class="icon-puzzle-piece fields users-groups" aria-hidden="true"></span>
(Users: Field Groups)
Category | Layout | ⇒ | Repository NPM Change Layout |
@brianteeman @sandewt issue fixed. I choose to use scss & map it instead of adding it to layout as we are going to be moving as much as we can from layout to scss in the near future.
But that's an entirely different pr.
Although it renders icon-puzzle-piece it is infact fas fa-puzzle-piece.
no you have just moved the issue to somewhere else. each one of these icon change prs just creates more issues elsewhere. please stop, undo all this stuff and then we can all (yourself included) concentrate on real issues instead of creating new ones.
no you have just moved the issue to somewhere else. each one of these icon change prs just creates more issues elsewhere. please stop, undo all this stuff and then we can all (yourself included) concentrate on real issues instead of creating new ones.
idk how you can justify that statement but your welcome to your opinion.
ITs simple really. Just count the number of PRs (open and closed) that have been created just to get back to the exact same situation that we had before you started the unnecessary change to not use "fa".
ITs simple really. Just count the number of PRs (open and closed) that have been created just to get back to the exact same situation that we had before you started the unnecessary change to not use "fa".
Where do you get the idea that i/we don't want to use FA? It's exactly the opposite issue!
if you mean the prefix "fa" then thats a valueless argument as there is no such VALID prefix in fa 5+.
valid prefix's are now FAS & FAB for the free icon family set. HOWEVER we're required to have the "icon-" icon family set work 100% at the same time. On top of that we're mandated to support unknown icon sets & have been encouraged to get as close to zero hard code as possible.
These are not easy to keep all at the same time.
Add to all that the fact that there are roughly 6 different ways to render an icon and you begin to get the most microscopic picture of what a task we truly face.
if you mean the prefix "fa" then thats a valueless argument as there is no such VALID prefix in fa 5+.
As I have said repeatedly before that is a false assumption
I give up.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-21 19:58:01 |
Closed_By | ⇒ | N6REJ | |
Labels |
Added:
NPM Resource Changed
|
Thanks all
I have tested this item✅ successfully on ae03c2b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30677.