[#30455] - [4.0] Media field fix
- Fixed in Code Base
- 25 Aug 2020
- Medium
- Build: 4.0-dev
- # 30455
- Diff
- dgrammatiko:4.0-dev_media_field
User tests: Successful: Unsuccessful:
Pull Request for Issue #30453 .
Summary of Changes
- Bug fix
- Remove duplicate bindings
Testing Instructions
- Download and install the module from @Razzo1987
- Create a Swiper Slider module
- Go to "Options" tab
- Select a Background Image
- Try to select a different image
- Remove the image with the X button
- Try to select an image
- add more fields and repeat the previous steps
Actual result BEFORE applying this Pull Request
Modal doesn't open as expected
Expected result AFTER applying this Pull Request
Modal opens as expected
Documentation Changes Required
Nope
PS a note here:
- All Bootstrap init functions need a similar approach, so whenever a Bootstrap component is added programmatically it can be initialised.
- This is largely unneeded if all the components were custom elements. Custom elements have lifecycle events and therefore the initialisation can happen on the
connectedCallback, no extra fuzz, they just work...
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
Work correctly on the custom module
Work correctly on my module with 2 different image
Do not work on my module with repeatable fields within an image
@Razzo1987
Please post here your module zip so that we can test.
@infograf768 @Razzo1987 please retest using @Razzo1987 's module
Edit Swiper Slider module:
Uncaught TypeError: Joomla.Bootstrap is undefined
joomla-field-media.js:231:11
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30455.
I'm testing with
Joomla! 4.0.0-beta4-dev+pr.30455
These packages were built based on commit 50a892acda4a8d677fe50d02b995c535ddc0e100 included in pull request 30455
These packages were built on Sun Aug 23 16:30:38 UTC 2020
from https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/30455/downloads/34914
and doesn't work
@Razzo1987 Just realised that the last commit was not processed, ask someone with Drone access to restart the task
I confirm https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/30455/downloads/34914/Joomla_4.0.0-beta4-dev+pr.30455-Development-Full_Package.zip have the same problem.
Attend for Drone - restart the task
@Razzo1987 Drone restarted. Please try again.
Doesn't work
Joomla! 4.0.0-beta4-dev+pr.30455
These packages were built based on commit 50a892acda4a8d677fe50d02b995c535ddc0e100 included in pull request 30455
These packages were built on Sun Aug 23 17:59:30 UTC 2020
Doesn't work
Well, the drone was restarted but there is no new zip file (check the time) so basically you've just tested an earlier version of this PR
Also use the new download link: https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/30455/downloads/34916/
I have tested this item
Works fine.
Question: could this patch have an impact on other modals (xtd)?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30455.
Question: could this patch have an impact on other modals (xtd)?
I doubt it will affect anything, basically what was done here is to expose the init functionality so it can be used by devs whenever adding programmatically modals. This is needed because all the components using the Bootstrap js need initialisation but custom elements don't need that kind of pampering, which for me is an improved DX.
| Status | Pending | ⇒ | Ready to Commit |
Trust you. ;) RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30455.
EDITED!
it's OK!
I have cache problems
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-25 09:08:30 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
Tks!
@infograf768 In current BETA Problem still exists: See #26711
and #28953
@dgrammatiko can you check again?
@Didldu-Florian change
to&& window.bootstrap.Modal.getInstance(this.modalElement) === null) {
Also if you do a PR please also apply the same fix here:
@dgrammatiko oh, nice, thanks :) That fix works.
But why does no PR exists for that?
I have tested this item✅ successfully on 79c4e01
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30455.