Feeling Lucky
?
?
[#30436] - [4.0] [a11y] Update _icomoon.scss px => rem
- Fixed in Code Base
- 31 Aug 2020
- Medium
- Build: 4.0-dev
- # 30436
- Diff
- hans2103:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue #29411 .
Summary of Changes
This small PR will replace the px set in _icomoon by rem.
Using relative sizes instead of absolute sizes will make this part of the Joomla a wee more a11y.
This PR is just a small piece of all replaces that have to be done.
Testing Instructions
- Open Jooml4 test and inspect element of an icon (in Chrome => use the shortcut
Cmd + Shift + C(Ctrl + Shift + Con Windows)) Your pointer is in Inspect Element mode, go ahead and click an element on the webpage - icon is present in the search form
- lookup the width, height and line-height
- apply PR and run
npm run build:css
Actual result BEFORE applying this Pull Request
Before PR the values of the items width, height and line-height are set to 14px
Expected result AFTER applying this Pull Request
After applying PR the values of the items width, height and line-height are set to 1rem
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
sandewt
- comment
- 21 Aug 2020
See comment
Screenshot after testing.
14 px remains 14 px and corresponds to 1 rem
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30436.
chmst
- comment
- 23 Aug 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30436.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 23 Aug 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30436.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-31 15:49:33 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
?
|
||
zero-24
- comment
- 31 Aug 2020
Merging thanks
I have tested this item✅ successfully on 29fdeaa
Joomla! 4.0.0-beta4-dev Development [ Mañana ] 29-July-2020 18:21 GMT
See comment.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30436.