? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
21 Aug 2020

Summary of Changes

Fieldset description as created in the layout is not a11y aware, misses info icon, prevents html in language string

This PR modifies the layout to obtain the same results we already have when we have no results in a manager.
Screen Shot 2020-08-21 at 09 44 57

Testing Instructions

Install French language. (it is a 3.x lang and one string still contains some <br> which will be taken off in J4)
Create a List All Categories menu item
Display the Category Tab (same for Blog Layout, List Layout)
Switch backend language between en-GB and fr-FR

Actual result BEFORE applying this Pull Request

English

Screen Shot 2020-08-21 at 09 18 43

French

Screen Shot 2020-08-21 at 09 19 25

Expected result AFTER applying this Pull Request

English

Screen Shot 2020-08-21 at 09 20 20

French

Screen Shot 2020-08-21 at 09 20 02

Code obtained:
Screen Shot 2020-08-21 at 09 32 25

avatar infograf768 infograf768 - open - 21 Aug 2020
avatar infograf768 infograf768 - change - 21 Aug 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Aug 2020
Category Layout
avatar ChristineWk ChristineWk - test_item - 21 Aug 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 21 Aug 2020

I have tested this item successfully on 5ff9b35


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30435.

avatar infograf768 infograf768 - alter_testresult - 21 Aug 2020 - obuisard: Tested successfully
avatar Quy Quy - change - 21 Aug 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 21 Aug 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30435.

avatar infograf768
infograf768 - comment - 21 Aug 2020

added @obuisard success test

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30435.

avatar infograf768
infograf768 - comment - 21 Aug 2020

@Quy lol

avatar Quy Quy - close - 21 Aug 2020
avatar Quy Quy - merge - 21 Aug 2020
avatar Quy Quy - change - 21 Aug 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-08-21 15:51:51
Closed_By Quy
Labels Added: ? ?
avatar Quy
Quy - comment - 21 Aug 2020

Thanks!

Add a Comment

Login with GitHub to post a comment