? NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
21 Aug 2020

Summary of Changes

As title says.

Testing Instructions

Allow user registration in Users Options
Register in frontend Cassiopea

Uses npm after patch

Actual result BEFORE applying this Pull Request

Screen Shot 2020-08-20 at 07 45 32

Expected result AFTER applying this Pull Request

This will work better (length) if #30424 is already merged in the testing branch.

Screen Shot 2020-08-21 at 11 53 40

There may be some cs. tbs after drone first pass.

avatar infograf768 infograf768 - open - 21 Aug 2020
avatar infograf768 infograf768 - change - 21 Aug 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Aug 2020
Category Administration Language & Strings Front End com_users Templates (site) NPM Change
avatar infograf768 infograf768 - change - 21 Aug 2020
Title
[4.0] {Cassiopea] Implementing Password length/meter
[4.0] [Cassiopea] Implementing Password length/meter
avatar infograf768 infograf768 - edited - 21 Aug 2020
avatar Magnytu2
Magnytu2 - comment - 21 Aug 2020

the graph is very small on Safari as on Chrome
Créer_un_compte-2

avatar infograf768
infograf768 - comment - 21 Aug 2020

This PR needs npm to add the class:

meter {
  width: 100%;
}

can't be tested with patch tester.
Also to get good results for the color bar, the test site must already contain #30424

avatar infograf768 infograf768 - change - 21 Aug 2020
The description was changed
avatar infograf768 infograf768 - edited - 21 Aug 2020
avatar Magnytu2
Magnytu2 - comment - 21 Aug 2020

I tried on my site with the PR 30424, but it is still small.

avatar infograf768
infograf768 - comment - 21 Aug 2020

both prs need npm to compile the scss.

avatar Quy Quy - test_item - 21 Aug 2020 - Tested successfully
avatar Quy
Quy - comment - 21 Aug 2020

I have tested this item successfully on 9697d5b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30437.

avatar richard67 richard67 - test_item - 21 Aug 2020 - Tested successfully
avatar richard67
richard67 - comment - 21 Aug 2020

I have tested this item successfully on 9697d5b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30437.

avatar richard67 richard67 - change - 21 Aug 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 21 Aug 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30437.

avatar richard67 richard67 - change - 21 Aug 2020
Labels Added: ? ? ? NPM Resource Changed
avatar infograf768 infograf768 - change - 22 Aug 2020
Labels
avatar infograf768
infograf768 - comment - 22 Aug 2020

Thanks @zero-24
Took off description. We have to implement another PR to display all the minimum rules defined in the Options.

We will not just get
Screen Shot 2020-08-22 at 11 18 07

Folks, please test again

avatar infograf768 infograf768 - change - 22 Aug 2020
Status Ready to Commit Pending
avatar infograf768
infograf768 - comment - 22 Aug 2020

Back to pending


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30437.

avatar richard67
richard67 - comment - 22 Aug 2020

@zero-24 Could you update your review so that the "Changes requested" disappears? I think it needs to approve the changes of this for that, marking conversation as revolved will not be enough, as far as I remember.

avatar richard67 richard67 - test_item - 22 Aug 2020 - Tested successfully
avatar richard67
richard67 - comment - 22 Aug 2020

I have tested this item successfully on cfced36


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30437.

avatar Quy Quy - test_item - 22 Aug 2020 - Tested successfully
avatar Quy
Quy - comment - 22 Aug 2020

I have tested this item successfully on cfced36


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30437.

avatar Quy Quy - change - 22 Aug 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 22 Aug 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30437.

avatar rdeutz rdeutz - change - 23 Aug 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-08-23 11:34:29
Closed_By rdeutz
avatar rdeutz rdeutz - close - 23 Aug 2020
avatar rdeutz rdeutz - merge - 23 Aug 2020

Add a Comment

Login with GitHub to post a comment