[#30382] - [4.0] Fixing Warning Alert color contrast
- Fixed in Code Base
- 16 Aug 2020
- Medium
- Build: 4.0-dev
- # 30382
- Diff
- infograf768:4.0_alert_warning
User tests: Successful: Unsuccessful:
Pull Request for Issue #30375
Summary of Changes
As title says. Changing Warning heading and Close button to black to increase contrast with Yellow background
Testing Instructions
Try to login with a wrong password. in frontend as well as backend
You will get a warning.
NPM after patch
Actual result BEFORE applying this Pull Request
Frontend
Backend
Expected result AFTER applying this Pull Request
Frontend
Backend
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change Front End Templates (site) |
I have tested this item
See my comment above.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30382.
Note: I miss the yellow border top of the warming message in the administrator, as it can be seen in the frontend.
This is only for the login page and the border is there, although just close to the header.
If desired, one could modify slightly the code in login.php to include <jdoc:include type="message" /> in a <div> with a specific class. Not sure it is necessary.
Thanks for testing.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30382.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30382.
| Labels |
Added:
?
?
NPM Resource Changed
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-16 10:04:09 |
| Closed_By | ⇒ | richard67 | |
| Labels | |||
Thanks to all (coder and testers).
If desired, one could modify slightly the code in login.php to include
<jdoc:include type="message" />in a<div>with a specific class. Not sure it is necessary.
I have tried something with an existing class for the look and feel.
Disadvantage: the login field always scrolls down 15 px.
File: login.php
<div class="contentpane">
<jdoc:include type="message" />
</div>
Result:
Next step?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30382.
A new class could be created in /administrator/templates/atum/scss/blocks/_login.scss
Something like
.login_message {
margin: 1rem 1rem 0 1rem; }
code in login.php
<section id="content" class="content h-100">
<div class="login_message"><jdoc:include type="message" /></div>
<main class="d-flex justify-content-center align-items-center h-100">
You can make PR.
See issue: #30400
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30382.
Joomla! 4.0.0-beta4-dev Development [ Mañana ] 29-July-2020 18:21 GMT
Joomla_4.0.0-beta4-dev+pr.30382-Development-Full_Package.zip
Note: I miss the yellow border top of the warming message in the administrator, as it can be seen in the frontend.
See test result below.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30382.