?
avatar Quy
Quy
15 Aug 2020

Steps to reproduce the issue

Upgrade to 4 Beta

In 3.10 this module's position is footer and in 4, it is status.

Expected result

Version should be displayed in the upper right corner.

Actual result

No version is displayed.

avatar Quy Quy - open - 15 Aug 2020
avatar joomla-cms-bot joomla-cms-bot - change - 15 Aug 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 15 Aug 2020
avatar infograf768
infograf768 - comment - 16 Aug 2020

I guess this can be solved by an sql update.

avatar richard67
richard67 - comment - 16 Aug 2020

I guess this can be solved by an sql update.

Yes, if the module can be clearly identified in a WHERE clause (what I think should be the case). Shall I try to make a PR?

avatar richard67
richard67 - comment - 16 Aug 2020

@Quy Would following be sufficient?

UPDATE `#__modules` SET `position`='status' WHERE `module`='mod_version' AND `client_id`=1;

Or should we also include the old position in the condition in case someone has published another mod_version somewhere else?

UPDATE `#__modules` SET `position`='status' WHERE `module`='mod_version' AND `client_id`=1 AND `position`='footer';
avatar richard67
richard67 - comment - 16 Aug 2020

Or do we need to restrict it even more?

avatar infograf768
infograf768 - comment - 16 Aug 2020

imho, if someone has set the mod_version in another position, it may anyway not fit to Atum.
Therefore I am rather in favor of

UPDATE `#__modules` SET `position`='status' WHERE `module`='mod_version' AND `client_id`=1;
avatar richard67 richard67 - change - 16 Aug 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-08-16 11:49:45
Closed_By richard67
avatar richard67
richard67 - comment - 16 Aug 2020

Closing as having a pull request. Please test #30383 .

avatar richard67 richard67 - close - 16 Aug 2020

Add a Comment

Login with GitHub to post a comment