? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
16 Aug 2020

Pull Request for Issue #30381 .

Summary of Changes

This Pull Request (PR) modifies the update SQL script for each database type which moves to the new templates when updating from 3.10 to 4 so that the Joomla Version backend module "mod_version" is moved to the "status" position of Atum, where it is located when making a new installation of J4.

Testing Instructions

Test 1: Reproduce the issue

  1. Update a recent 3.10-dev branch or 3.10 nightly build to latest 4.0 nightly by using either the custom update URL or the downloadable update package from https://developer.joomla.org/nightly-builds.html.

  2. After successful update and login to backend, check if you can find the icon marked with a red ellipse in the following screenshot.

j4-mod-version

Result: The icon can't be found anywhere in the backend.

Test 2: Test the patch of this PR

Same as test 1, but this time don't use the regular custom update URL or the downloadable update package for J4 nightlies.

Use the custom URL or package which have been built for this PR.

You can find a page with a link to an installation package for download as shown in the following screenshot with the green ellipse (if necessary expand the "Show all checks" to see that):
pr-downloads

Result: The icon is shown at the right place as shown in the screenshot of Test 1.

Actual result BEFORE applying this Pull Request

No version is displayed.

Expected result AFTER applying this Pull Request

Version should be displayed in the upper right "status" position in the backend.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 16 Aug 2020
avatar richard67 richard67 - change - 16 Aug 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Aug 2020
Category SQL Administration com_admin Postgresql
avatar richard67 richard67 - change - 16 Aug 2020
The description was changed
avatar richard67 richard67 - edited - 16 Aug 2020
avatar richard67
richard67 - comment - 16 Aug 2020

Hmm, wait, maybe I should not make new scripts which would also run when updating a previous 4 beta version but put the statements into the oldest update SQL so it runs only when updating a 3.10?

avatar richard67 richard67 - change - 16 Aug 2020
Labels Added: ?
avatar richard67
richard67 - comment - 16 Aug 2020

I've reverted the new update sql scripts and have put the update statement into the same update script which changes the templates, so it only runs when updating a 3.10.

avatar richard67 richard67 - change - 16 Aug 2020
The description was changed
avatar richard67 richard67 - edited - 16 Aug 2020
avatar infograf768
infograf768 - comment - 16 Aug 2020

Looks ok on review

avatar Quy Quy - test_item - 16 Aug 2020 - Tested successfully
avatar Quy
Quy - comment - 16 Aug 2020

I have tested this item successfully on ae3a32a

Thank you!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30383.

avatar alikon alikon - test_item - 19 Aug 2020 - Tested successfully
avatar alikon
alikon - comment - 19 Aug 2020

I have tested this item successfully on ae3a32a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30383.

avatar alikon alikon - change - 19 Aug 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 19 Aug 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30383.

avatar infograf768 infograf768 - close - 19 Aug 2020
avatar infograf768 infograf768 - merge - 19 Aug 2020
avatar infograf768 infograf768 - change - 19 Aug 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-08-19 07:33:38
Closed_By infograf768
Labels Added: ?
avatar infograf768
infograf768 - comment - 19 Aug 2020

Tks.

Add a Comment

Login with GitHub to post a comment