User tests: Successful: Unsuccessful:
Pull Request for Issue # .
repaired preview icon lost in last pr
go to System > Site Templates > Cassiopeia Details and Files > Template Preview button and verify the image icon "fas fa-image" is there
no icon present
none
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_templates |
I have tested this item
Restarted drone.
Note: Looks I forgot to add that preview button for admin templates.
Restarted drone.
What do you mean?
Note: Looks I forgot to add that preview button for admin templates.
Right, it will link to the site instead of seeing a preview of the template.
Status | Pending | ⇒ | Ready to Commit |
RTC
@N6REJ
Could you please update your branch from origin to solve the drone issue?
Also, as you are at it, I suggest you add the Preview button for admin template.
The whole block of code should be
// Add a Template preview button
$client = (int) $this->preview->client_id === 1 ? 'administrator/' : '';
if ($this->type === 'home')
{
$bar->linkButton('preview')
->icon('fas fa-image')
->text('COM_TEMPLATES_BUTTON_PREVIEW')
->url(Uri::root() . $client . 'index.php?tp=1&templateStyle=' . $this->preview->id)
->attributes(['target' => '_new']);
}
I tested it fine. I can also do in a new PR if you prefer.
Labels |
Added:
?
?
|
@N6REJ
Could you please update your branch from origin to solve the drone issue?Also, as you are at it, I suggest you add the Preview button for admin template.
I tested it fine. I can also do in a new PR if you prefer.
done
However the preview buttons doesn't work correctly.
It takes you back to dashboard via /administrator/index.php?tp=1&templateStyle=10
but thats for another pr
However the preview buttons doesn't work correctly.
It takes you back to dashboard via /administrator/index.php?tp=1&templateStyle=10
It does not take you back but opens a new window with modules positions.
That is perfectly fine imho.
Relaunched drone again.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-01 23:56:41 |
Closed_By | ⇒ | Quy |
I have tested this item✅ successfully on 59c1ab8
Result:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30242.