? ? Pending

User tests: Successful: Unsuccessful:

avatar N6REJ
N6REJ
31 Jul 2020

Pull Request for Issue # .

Summary of Changes

repaired preview icon lost in last pr

Testing Instructions

go to System > Site Templates > Cassiopeia Details and Files > Template Preview button and verify the image icon "fas fa-image" is there

Actual result BEFORE applying this Pull Request

no icon present

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

none

avatar N6REJ N6REJ - open - 31 Jul 2020
avatar N6REJ N6REJ - change - 31 Jul 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Jul 2020
Category Administration com_templates
avatar sandewt sandewt - test_item - 31 Jul 2020 - Tested successfully
avatar sandewt
sandewt - comment - 31 Jul 2020

I have tested this item successfully on 59c1ab8

Result:

<span class="fas fa-image" aria-hidden="true"></span>

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30242.
avatar infograf768 infograf768 - test_item - 31 Jul 2020 - Tested successfully
avatar infograf768
infograf768 - comment - 31 Jul 2020

I have tested this item successfully on 59c1ab8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30242.

avatar infograf768
infograf768 - comment - 31 Jul 2020

Restarted drone.
Note: Looks I forgot to add that preview button for admin templates.

avatar sandewt
sandewt - comment - 31 Jul 2020

Restarted drone.

What do you mean?

Note: Looks I forgot to add that preview button for admin templates.

Right, it will link to the site instead of seeing a preview of the template.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30242.

avatar Quy Quy - change - 31 Jul 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 31 Jul 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30242.

avatar infograf768
infograf768 - comment - 31 Jul 2020

@N6REJ
Could you please update your branch from origin to solve the drone issue?

Also, as you are at it, I suggest you add the Preview button for admin template.
The whole block of code should be

		// Add a Template preview button
		$client = (int) $this->preview->client_id === 1 ? 'administrator/' : '';

		if ($this->type === 'home')
		{
			$bar->linkButton('preview')
				->icon('fas fa-image')
				->text('COM_TEMPLATES_BUTTON_PREVIEW')
				->url(Uri::root() . $client . 'index.php?tp=1&templateStyle=' . $this->preview->id)
				->attributes(['target' => '_new']);
		}

I tested it fine. I can also do in a new PR if you prefer.

avatar N6REJ N6REJ - change - 31 Jul 2020
Labels Added: ? ?
avatar N6REJ
N6REJ - comment - 31 Jul 2020

@N6REJ
Could you please update your branch from origin to solve the drone issue?

Also, as you are at it, I suggest you add the Preview button for admin template.

I tested it fine. I can also do in a new PR if you prefer.

done

However the preview buttons doesn't work correctly.
It takes you back to dashboard via /administrator/index.php?tp=1&templateStyle=10
but thats for another pr

avatar infograf768
infograf768 - comment - 1 Aug 2020

However the preview buttons doesn't work correctly.
It takes you back to dashboard via /administrator/index.php?tp=1&templateStyle=10

It does not take you back but opens a new window with modules positions.
That is perfectly fine imho.

Relaunched drone again.

avatar Quy Quy - change - 1 Aug 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-08-01 23:56:41
Closed_By Quy
avatar Quy Quy - close - 1 Aug 2020
avatar Quy Quy - merge - 1 Aug 2020

Add a Comment

Login with GitHub to post a comment