[#30241] - [4.0] Resizing template editor causes multiple editor instances #22778 #30240
- Fixed in Code Base
- 9 Aug 2020
- Medium
- Build: 4.0-dev
- # 30241
- Diff
- shim-sao:4.0-dev
- Pending continuous-integration/drone/pr Build is running Details
- Error continuous-integration/appveyor/pr AppVeyor build cancelled Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #22778 .
Summary of Changes
Avoid codemirror editor duplication when we are trying to resize the page.
Testing Instructions
Use codemirror as editor
Try to resize the page
Try to click on add readmore or something else
Actual result BEFORE applying this Pull Request
The editor is duplicated each time we are doing a resize of the page
Expected result AFTER applying this Pull Request
A single instance of the editor
Add readmore and other button should work
Documentation Changes Required
To test the patch, use npm run build:js to build the final file admin-article-readmore.min.js.gz
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
I have tested this item
I could reproduce the issue with having multiple instances of the codemirror editor e.g. in the template details file edit view after having resized the broswer windows from large to small and back to large, and I could verify that this PR fixes it.
Browser is Firefox 78.0.2 (64-Bit) on Windows 10.
Hint for other testers: It needs to run npm to build the changed js.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30241.
Sorry, I don't use npm, I have just tested directly by creating the gzip file with 7z
That's also a way if only such small changes. Anyway, it needs a 2nd good test, then it will get RTC status, which means ready to commit, and then it will be ready for final review and merge by a maintainer.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30241.
@shim-sao For developing (s)css or js stuff in Joomla 4 it needs npm if your are not sure where to copy the files to and to which js standard to transpile them to, too, and for some PHP stuff sometimes composer. You can find the details about how to set up a development environment here: https://docs.joomla.org/J4.x:Setting_Up_Your_Local_Environment. At a first look that might seem oversized to you, but I was told by people that that's the future in web development.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30241.
| Labels |
Added:
?
?
NPM Resource Changed
|
||
No problem for the technologies, I know how all is working.
I discover a little how Joomla 4 is done and the work in/of the team.
I've always wanted to help without daring, so I'm going for it. I will do things cleaner in the future
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-09 22:49:03 |
| Closed_By | ⇒ | wilsonge | |
| Labels | |||
This is still an issue in 4.0.0-rc1.
@shim-sao Could you add a hint in the testing instructions that it needs to run npm after having applied the change of this PR in order to get the js built? Not every tester knows that. Thanks in advance.