? NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
31 Jul 2020

Pull Request for Issue #30230

Summary of Changes

This let's translate the dir and file types

Testing Instructions

Set Debug Language on.
Load Media Manager, select a folder and click on the i to get the informations
Do the same for a file.

Patch. Run npm

Actual result BEFORE applying this Pull Request

The Type is not translated

Screen Shot 2020-07-31 at 11 21 14

Screen Shot 2020-07-31 at 11 21 03

Expected result AFTER applying this Pull Request

Screen Shot 2020-07-31 at 11 18 32

Screen Shot 2020-07-31 at 11 18 16

avatar infograf768 infograf768 - open - 31 Jul 2020
avatar infograf768 infograf768 - change - 31 Jul 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Jul 2020
Category Administration com_media NPM Change Language & Strings
avatar infograf768 infograf768 - change - 31 Jul 2020
Labels Added: ? NPM Resource Changed ?
avatar infograf768
infograf768 - comment - 31 Jul 2020

@Quy
Done.

avatar Quy
Quy - comment - 31 Jul 2020

I am not on a computer to test. Can you check line 8 for translation?

avatar infograf768
infograf768 - comment - 31 Jul 2020

Can you check line 8 for translation?

It is not even displayed here in source.

avatar Quy
Quy - comment - 31 Jul 2020
avatar infograf768
infograf768 - comment - 31 Jul 2020

I know where it is in the file. As I said, when the page is loaded, I do not see it displayed in source.

avatar Quy Quy - test_item - 31 Jul 2020 - Tested successfully
avatar Quy
Quy - comment - 31 Jul 2020

I have tested this item successfully on 10e0737


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30243.

avatar Quy
Quy - comment - 31 Jul 2020

Ignore it for now. I will open an issue if I can reproduce it. Thanks.

avatar yasin-96 yasin-96 - test_item - 3 Aug 2020 - Tested successfully
avatar yasin-96
yasin-96 - comment - 3 Aug 2020

I have tested this item successfully on 10e0737

After Installed the patch and run the npm ci command the media type where translated correctly.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30243.

avatar david0296 david0296 - test_item - 3 Aug 2020 - Tested successfully
avatar david0296
david0296 - comment - 3 Aug 2020

I have tested this item successfully on 10e0737

After applying and running npm ci, the Type is translated


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30243.

avatar Quy Quy - change - 3 Aug 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 3 Aug 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30243.

avatar Quy Quy - close - 3 Aug 2020
avatar Quy Quy - merge - 3 Aug 2020
avatar Quy Quy - change - 3 Aug 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-08-03 14:28:20
Closed_By Quy
Labels Added: ?

Add a Comment

Login with GitHub to post a comment