Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#30188] - [4.0] mod_syndicate a11y and more

? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
25 Jul 2020

Problem

  1. the alt text contains the word image which is not recommended
  2. the alt text is hardcoded and not translatable
  3. When the text is displayed then the alt text is not needed as it does not convey any meaning
  4. When the text is not displayed then the use of the image as a link with an alt of feed-image does not convey the meaning of the link

Solution

  1. remove the alt text completely and replace with empty alt
  2. when the text is not displayed give it a sr-only class so that the link has meaning instead of just removing it completely
  3. as a result change some language strings and re-order the fields so that they make more sense and remove the show-on

Testing

If you dont already have a syndication module then create one

The changes are visible in the config of the module

Before

image

After

image

In the frontend the changes are only visible in the markup of the module

After - with Label

image

After - without label

image

avatar brianteeman brianteeman - open - 25 Jul 2020
avatar brianteeman brianteeman - change - 25 Jul 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jul 2020
Category ⇒ Language & Strings Modules Front End
avatar brianteeman brianteeman - change - 25 Jul 2020
Labels Added: ? ?
avatar particthistle particthistle - test_item - 26 Jul 2020 - Tested successfully
avatar particthistle
particthistle - comment - 26 Jul 2020

I have tested this item ✅ successfully on 6438a9a

Test successfully - results matched test instruction example results.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30188.

avatar bonzani bonzani - test_item - 26 Jul 2020 - Tested successfully
avatar bonzani
bonzani - comment - 26 Jul 2020

I have tested this item ✅ successfully on 6438a9a

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30188.

avatar richard67 richard67 - change - 26 Jul 2020
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 26 Jul 2020

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30188.

avatar Quy Quy - change - 26 Jul 2020
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-07-26 14:02:05
Closed_By ⇒ Quy
Labels Added: ?
avatar Quy Quy - close - 26 Jul 2020
avatar Quy Quy - merge - 26 Jul 2020
avatar brianteeman
brianteeman - comment - 26 Jul 2020

Thanks

Add a Comment

Login with GitHub to post a comment