? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
25 Jul 2020

Not sure why there was a layout override here but it breaks in joomla 4

Before the PR to remove the override the descriptions are not present and this also makes the aria markup invalid

Removing the layout override and the descriptions are back and the markup is valid

PS not sure if this can be tested with patchtester as it deletes a file

Before

image

After

image

avatar brianteeman brianteeman - open - 25 Jul 2020
avatar brianteeman brianteeman - change - 25 Jul 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jul 2020
Category Front End com_users
avatar particthistle particthistle - test_item - 26 Jul 2020 - Tested successfully
avatar particthistle
particthistle - comment - 26 Jul 2020

I have tested this item successfully on 7235205

@brianteeman you're correct - PR can't be tested by applying patch in patch tester, as it's a file deletion.

  • Navigated to components/com_users/layouts/joomla/form/
  • Renamed renderfield.php to renderfield.bak for testing
  • Tested change successfully
  • Renamed renderfield.bak back to renderfield.php to restore file (optional).
    This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30189.
avatar bonzani bonzani - test_item - 26 Jul 2020 - Tested successfully
avatar bonzani
bonzani - comment - 26 Jul 2020

I have tested this item successfully on 7235205


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30189.

avatar richard67 richard67 - change - 26 Jul 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 26 Jul 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30189.

avatar richard67 richard67 - change - 26 Jul 2020
Labels Added: ? ?
avatar Quy
Quy - comment - 27 Jul 2020

Now there is help text under Email that is almost identical to the paragraph above.

avatar brianteeman
brianteeman - comment - 2 Aug 2020

Closed as this was not correct

avatar brianteeman brianteeman - change - 2 Aug 2020
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2020-08-02 15:15:14
Closed_By brianteeman
Labels
avatar brianteeman brianteeman - close - 2 Aug 2020

Add a Comment

Login with GitHub to post a comment