[#30159] - [4.0] [template.cassiopeia] replacing div selector by * for module styling
- Closed
- 21 Jul 2020
- Medium
- Build: staging
- # 30159
- Diff
- hans2103:feature/css-wildcard-instead-of-div-for-children-of-container
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR fixes module spacing when selecting a module tag other than div.
After applying this PR the spacing between modules is reduced since margin-bottom is removed.
All spacing should be accomplished by the lobotomized owl selector * + *. Not by using both margin-top and margin-bottom on modules.
Testing Instructions
-
Make sure some kind of Sample Data is applied and Cassiopeia is default frontend template.
-
Joomla administrator > Content > Site Modules
-
Open module "Popular Tags" assigned to position
sidebar-right(this is the second module shown in sidebar-right) -
Go to tab Advanced
-
Change Module Tag from
divtoaside -
Save & Close
-
Refresh frontend
-
Apply PR
-
Open terminal to run
npm build:csson Joomla root -
Refresh frontend to see effect AFTER PR
Actual result BEFORE applying this Pull Request
Chosen Module Tag === div
Chosen Module Tag !== div
Expected result AFTER applying this Pull Request
Chosen Module Tag .... all
Documentation Changes Required
I don't know if changes on documentation is required.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository Administration |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-21 19:55:15 |
| Closed_By | ⇒ | hans2103 | |
| Labels |
Added:
?
?
|
||
| Category | Unit Tests Repository Administration | ⇒ | Front End Templates (site) NPM Change |
forgive me... had chosen the wrong base (staging). I've changed it to the right one (4.0-dev)
I will close this issue and create a new one.