[#30160] - [4.0] [template.cassiopeia] replacing div selector by * for module spacing
- Fixed in Code Base
- 4 Aug 2020
- Medium
- Build: 4.0-dev
- # 30160
- Diff
- hans2103:feature/css-wildcard-instead-of-div-elements
- Failure continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request Details
- Failure continuous-integration/drone/pr Build is failing Details
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR fixes module spacing when selecting a module tag other than div.
After applying this PR the spacing between modules is reduced since margin-bottom is removed.
All spacing should be accomplished by the lobotomized owl selector * + *. Not by using both margin-top and margin-bottom on modules.
Testing Instructions
-
Make sure some kind of Sample Data is applied and Cassiopeia is default frontend template.
-
Joomla administrator > Content > Site Modules
-
Open module "Popular Tags" assigned to position
sidebar-right(this is the second module shown in sidebar-right) -
Go to tab Advanced
-
Change Module Tag from
divtoaside -
Save & Close
-
Refresh frontend
-
Apply PR
-
Open terminal to run
npm build:csson Joomla root -
Refresh frontend to see effect AFTER PR
Actual result BEFORE applying this Pull Request
Chosen Module Tag === div
Chosen Module Tag !== div
Expected result AFTER applying this Pull Request
Chosen Module Tag .... all
Documentation Changes Required
I don't know if changes on documentation is required.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
@dgrammatiko Thumbs up for the lobotomised owl
?
can you test the PR too please?
I have tested this item
Tested with Chrome on Win64
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30160.
I have tested this item
Tested Succesfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30160.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30160.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-04 22:17:05 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
Thumbs up for the lobotomised owl?