? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
17 Jul 2020

Pull Request for Issue #28374 .

Summary of Changes

Remove collapse class when resizing from mobile to desktop to display sidebar nav.

Steps to reproduce the issue

Go to /administrator/index.php?option=com_config&view=component&component=com_content
Reduce viewport width down so everything gets stacked
Click the Toggle Menu button so the menu is hidden
Increase viewport width back to desktop size
Apply PR.
Run npm i or install the package installer:

Expected result

Menu is becomes visible

Actual result

Menu is stilll hidden

screeny1

avatar Quy Quy - open - 17 Jul 2020
avatar Quy Quy - change - 17 Jul 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jul 2020
Category JavaScript Repository NPM Change
avatar richard67 richard67 - test_item - 19 Jul 2020 - Tested successfully
avatar richard67
richard67 - comment - 19 Jul 2020

I have tested this item successfully on 4663d3b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30132.

avatar Quy Quy - change - 19 Jul 2020
Title
[4.0] Display sidebar nav when resizing from mobile to desktop
[4.0] Display sidebar nav/toolbar when resizing from mobile to desktop
avatar Quy Quy - edited - 19 Jul 2020
avatar bonzani bonzani - test_item - 19 Jul 2020 - Tested successfully
avatar bonzani
bonzani - comment - 19 Jul 2020

I have tested this item successfully on 4663d3b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30132.

avatar richard67 richard67 - change - 19 Jul 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 19 Jul 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30132.

avatar richard67 richard67 - change - 19 Jul 2020
Labels Added: ? ?
avatar Quy Quy - close - 20 Jul 2020
avatar Quy Quy - merge - 20 Jul 2020
avatar Quy Quy - change - 20 Jul 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-07-20 20:00:47
Closed_By Quy
Labels

Add a Comment

Login with GitHub to post a comment