User tests: Successful: Unsuccessful:
Fixes #27958.
Use the correct class to fix toolbar collapse in mobile view.
Apply PR.
Run npm i or install the package installer: https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/30131/downloads/35475/
Resize browser's viewport.
Go to Global Configuration.
Go to any list views.
The toolbar toggle button requires 2 clicks to close. The first click attempts to open the already open toolbar.
Toolbar collapsed by default.
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript Repository NPM Change |
Ahh, so both PRs together should do the job.
@Quy No, the issue persists when I apply the changes of both PRs (this one here and #30132 ).
For display widths of 768 px or larger, the tool bar is shown, all fine.
For display widths between 576 and 767 px, the toolbar is not shown, but also not the button for it.
For display widths of 757 px or smaller, the button is shown:
Labels |
Added:
NPM Resource Changed
?
|
Went to test this but the link to the PR files: https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/30131/downloads/34008/ Gives File not found on all the downloads :(
Also when I went to apply the PR there was nothing able to be applied.
Modified per BFH discussion to indicate the failed test was not an actual test.
Gives File not found on all the downloads :(
Also when I went to apply the PR there was nothing able to be applied.
@particthistle Both is not fault of this PR. The first one is caused by an erroneout cleanup script having cleaned up the wrong stuff, the 2nd thing is a patchtester thing.
So please change your test result back to "not tested" (can be done in the issue tracker by using the "Test this" button again).
It can never be the fault of a PR when something is wrong with inbfrastructure or test tools.
@Quy I've just tested again and my comment above is still valid:
when resizing from small to a bit larger, the burger button disappears, but the (collapsed) menu doesn't appear.
@Quy It seems the issue I've found is not related to this PR. Will continue to investigate and if necessary make new issue or PR. Could you fix the javascript cs error reported here https://ci.joomla.org/joomla/joomla-cms/35436/1/23 ? After that I can give this PR a good test.
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-19 10:00:21 |
Closed_By | ⇒ | infograf768 | |
Labels |
Added:
?
|
Tks
I have tested this item✅ successfully on 91ff85b
PR works as decribed.
But there is another issue with the toolbar collapse not related to this PR, i.e. it is there with and without this PR.
When resizing the browser window, the toolbar collapsing and the gears button display doesn't happen at the same time. Especially when enlarging the window, first the gears button disappears, but for making the tool bar appear it needs to further enlarge the window, i.e. there is a small diplay width range in with neither the gears button to expand or collapse the toolbar nor the expanded toolbar are shown.
@Quy I guess that's a css problem. Do you think you can fix that, too? And do you know if there is an issue for that?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30131.