? ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
4 Jul 2020

Summary of Changes

Compare #29962 or #29594 - fix the layout of modals if no item is found.

Testing Instructions

code review is sufficient. but if you want:

  1. newsfeed
    I suppose that you have no newsfeeds defined.
    If you want to add new menu item "single news feed" to your Menu, you must select a feed. A modal is opened.

  2. fields
    In general you never will see this modal if it is empty - so code review only

Actual result BEFORE applying this Pull Request

Searchtools and message are in a row

Expected result AFTER applying this Pull Request

As usual: Searchtools in a row and message in a row for its own.

Documentation Changes Required

no

avatar chmst chmst - open - 4 Jul 2020
avatar chmst chmst - change - 4 Jul 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jul 2020
Category Administration com_fields com_newsfeeds
avatar ChristineWk ChristineWk - test_item - 4 Jul 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 4 Jul 2020

I have tested this item successfully on c22e18b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29969.

avatar chmst chmst - change - 4 Jul 2020
Labels Added: ?
avatar richard67 richard67 - test_item - 4 Jul 2020 - Tested successfully
avatar richard67
richard67 - comment - 4 Jul 2020

I have tested this item successfully on c22e18b

Code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29969.

avatar richard67 richard67 - change - 4 Jul 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 4 Jul 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29969.

avatar Quy Quy - change - 4 Jul 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-07-04 19:00:57
Closed_By Quy
Labels Added: ?
avatar Quy Quy - close - 4 Jul 2020
avatar Quy Quy - merge - 4 Jul 2020

Add a Comment

Login with GitHub to post a comment