? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
4 Jul 2020

This PR does the following

  1. removes unused strings
  2. changes labelclass="d-none" to hiddenLabel in the xml
  3. adds missing labels (even if they are not visible)

ToDo in a later PR change the radio buttons in rotate to real buttons in a button group. The current code breaks accessibility but thats for another PR

avatar brianteeman brianteeman - open - 4 Jul 2020
avatar brianteeman brianteeman - change - 4 Jul 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jul 2020
Category Administration Language & Strings Front End Plugins
0a7ea69 4 Jul 2020 avatar brianteeman xml
avatar brianteeman brianteeman - change - 4 Jul 2020
Labels Added: ? ?
avatar ChristineWk ChristineWk - test_item - 4 Jul 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 4 Jul 2020

I have tested this item successfully on 0a7ea69


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29970.

avatar Quy Quy - test_item - 4 Jul 2020 - Tested successfully
avatar Quy
Quy - comment - 4 Jul 2020

I have tested this item successfully on 0a7ea69


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29970.

avatar Quy Quy - change - 4 Jul 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 4 Jul 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29970.

avatar Quy Quy - close - 4 Jul 2020
avatar Quy Quy - merge - 4 Jul 2020
avatar Quy Quy - change - 4 Jul 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-07-04 22:36:53
Closed_By Quy
Labels Added: ?
avatar brianteeman
brianteeman - comment - 4 Jul 2020

thanks

Add a Comment

Login with GitHub to post a comment