Ok looks like its not possible to overwrite the default Symfony error page just yet as its hard coded into the symfony/error-handler, I'll work on that upstream first so that its possible in the future.

Upstream Submitted. symfony/symfony#37492

Upstream PR Approved and awaiting merging.... will be released with Symfony 5.2 in November, before that I'll PR for Joomla to use that new feature of the symfony/error-handler to display a customised and translatable error page instead of the Symfony default.

This has now been merged upstream for inclusion in Symfony 5.2 - this means Joomla can now have a customisable, translatable error page ??

The question for me is "How?". Or will you provide a pr then?

Well between now and November we need to add one single line to joomla (as per my example in the readme of the upstream pr) next to the line enabling the symfony error handler and point that to a custom system template that contains very little logic in it (based on views/error.twig.html), and some way of translating it without assuming anything is loaded - as this template is only ever used when something drastic is wrong and therefore cannot assume anything is booted.

It would be nice if this could also be customised without losing changes on joomla upgrade - maybe check for a custom version first and fall back to joomla provided version of the template?

For look and fee I was thinking to just copy the template used when you checkout from git without building your assets and just make it more red than blue.

We could ship joomla 4 with the dev-master release of symfony/error-handler to get this feature now or else we would need to wait for symfony 5.2 to be released in November

Sent from my iPhone

On 7 Jul 2020, at 15:22, ReLater notifications@github.com wrote:


The question for me is "How?". Or will you provide a pr then?

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.

PR #30056