Feeling Lucky
NPM Resource Changed
?
?
[#29894] - [4.0] Hide and disable "More Results" button in Language Overrides when no more results
- Fixed in Code Base
- 4 Jul 2020
- Medium
- Build: 4.0-dev
- # 29894
- Diff
- SharkyKZ:j4/js/language-override-button
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Hides and disables "More Results" button when there are no more results.
Testing Instructions
Requires node build.js --compile-js.
Go to create a Language Override.
Select English (United Kingdom) - Site language and client.
Search for a term that returns multiple pages, e.g. Version.
Keep clicking on "More Results" button.
Actual result BEFORE applying this Pull Request
Button is always clickable. When on last page, the same results keep getting returned.
Expected result AFTER applying this Pull Request
Button is clickable while there are unique pages and then disappears.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_languages JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
jwaisner
- comment
- 2 Jul 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29894.
| Status | Pending | ⇒ | Ready to Commit |
jwaisner
- comment
- 2 Jul 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29894.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-04 16:34:17 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
infograf768
- comment
- 4 Jul 2020
Tks.
I have tested this item✅ successfully on 23c2190
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29894.