Feeling Lucky
?
[#29806] - remove dead code $items is not used
- Closed
- 28 Jun 2020
- Medium
- Build: 4.0-dev
- # 29806
- Diff
- PhilETaylor:removedeaditemscall
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
removing dead code, the resultant $items is not used and the method call adds nothing but overhead to the run
Testing Instructions
Code review only needed
All that I removed was the following which someone has already annotated for removal
// @TODO: $items is not used. Remove this line?
$items = $categoryModel->getItems();
Actual result BEFORE applying this Pull Request
Newsfeeds work
Expected result AFTER applying this Pull Request
Newsfeeds still work
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_newsfeeds |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-28 16:51:09 |
| Closed_By | ⇒ | PhilETaylor | |
| Labels |
Added:
?
|
||
Closing to rebase on
staginginstead of 4.0-dev