[#29805] - remove dead code, remove use of $data as it doesnt exist in the scope
- Fixed in Code Base
- 4 Aug 2020
- Medium
- Build: 4.0-dev
- # 29805
- Diff
- PhilETaylor:com_config.config.global.data
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Remove dead code.
This code has never worked as $data doesnt exist in the scope
Its a copy and paste error from other controllers like
Testing Instructions
Hard to test as you would need to simulate a save failure
Actual result BEFORE applying this Pull Request
When editing the "Display Template Options" on the frontend - everything saves ok
If there was ever a condition (like ACL changed AFTER the form loaded) where the save failed, $data would not be "a thing" and so could not be saved to the session state and depending on PHP error reporting could show an undefined var notice
Expected result AFTER applying this Pull Request
When editing the "Display Template Options" on the frontend - everything saves ok
No notices on save failure
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_config |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29805.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29805.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-04 22:32:52 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
Thanks!
I have tested this item✅ successfully on 560e117
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29805.