[#29807] - Remove $items that is not used
- Fixed in Code Base
- 4 Aug 2020
- Medium
- Build: staging
- # 29807
- Diff
- PhilETaylor:removedeadcode
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
removing dead code, the resultant $items is not used and the method call adds nothing but overhead to the run
Testing Instructions
Code review only needed
All that I removed was the following which someone has already annotated for removal
// @TODO: $items is not used. Remove this line?
$items = $categoryModel->getItems();
Actual result BEFORE applying this Pull Request
Newsfeeds work
Expected result AFTER applying this Pull Request
Newsfeeds still work
Documentation Changes Required
None
Closes #29806 which was based on 4.0-dev, this is a rework on staging although the files are different Im hoping @wilsonge merges these things up?
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_newsfeeds |
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29807.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29807.
And why didn't you remove the getModel part completely?
I went for the "light touch" approach ;-) I dont want to break anything haha and this was clearly wrong and easy to remove.
Actually, @HLeithner Im not following what you mean.
haha and now we have a new unused variable ;-)
At least I can't see that $categoryModel is used in the function maybe I'm wrong.
| Labels |
Added:
?
|
||
@HLeithner I have tested and you are right - the whole block can be removed.
@jwaisner @ChristineWk this needs testing again before RTC thanks :)
I have tested this item
blank now :-)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29807.
I have tested this item
Tested successfully in 3.9.20-dev Nightly Build of 29 June.
Environment: Wampserver 3.2.2 Apache 2.4.43 MySQL 8.0.20 PHP 7.4.7.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29807.
continuous-integration/appveyor/pr — AppVeyor build failed
Not related to this PR change :)
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-04 22:29:50 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
I have tested this item✅ successfully on 0627aab
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29807.