?
avatar PhilETaylor
PhilETaylor
21 Jun 2020

Steps to reproduce the issue

Access Joomla 4 over a SSL
Go to /administrator/

Expected result

The web authentication button has a SVG image before the text as per the HTML

<button type="button" class="btn btn-secondary btn-block mt-4 plg_system_webauthn_login_button" data-webauthn-form="form-login" data-webauthn-url="https://63ed3465f24a.ngrok.io/administrator/index.php?3d507c383e47b5c680acae0417c95fea=1" title="Web Authentication" id="plg_system_webauthn-Aw2edsB6Pl3z-uibrG6pn">
									<img src="/media/plg_system_webauthn/images/webauthn-black.png" alt="Login without a password using the W3C Web Authentication (WebAuthn) standard in compatible browsers. You need to have already set up WebAuthn authentication in your user profile." class="icon" loading="lazy">								Web Authentication			</button>

Actual result

Screenshot 2020-06-21 at 13 01 04

System information (as much as possible)

Safari on Mac

Screenshot 2020-06-21 at 13 03 12

Additional comments

// @nikosdion

avatar PhilETaylor PhilETaylor - open - 21 Jun 2020
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jun 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 21 Jun 2020
avatar nikosdion
nikosdion - comment - 22 Jun 2020

This is a CSS issue. I don't touch that, I will only make it worse. @C-Lodder may I please make the bat signal, kind sir?

avatar PhilETaylor
PhilETaylor - comment - 22 Jun 2020

While I have you dressed in your Batman costume, it also appears the text is a different size/font? to the Log in button?

avatar C-Lodder
C-Lodder - comment - 22 Jun 2020

Issue caused by this block of CSS: https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/templates/atum/scss/blocks/_login.scss#L38-L41

Remove it and the image shows correctly

avatar PhilETaylor
PhilETaylor - comment - 22 Jun 2020

Remove it and the image shows correctly

And breaks a million other things? It feels like a trap, looks like that change was 16 months ago :-)

avatar C-Lodder
C-Lodder - comment - 22 Jun 2020

Well as far as I can tell, there are no <img> elements inside the .login div, other than those used by WebAuthn, so removing it should be fine

avatar PhilETaylor
PhilETaylor - comment - 22 Jun 2020

From what I understand, the new onUserLoginButtons, there can be other buttons (and other buttons could have images)

bad example:

83941813-0ae8a180-a7f7-11ea-9f6a-c3c60a496679

avatar N6REJ
N6REJ - comment - 9 Oct 2020

pr #31028

avatar N6REJ N6REJ - change - 9 Oct 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-10-09 20:53:44
Closed_By N6REJ
avatar N6REJ N6REJ - close - 9 Oct 2020

Add a Comment

Login with GitHub to post a comment