Feeling Lucky
?
?
[#29732] - Suggest text change of PR Template to make it more clear
- Fixed in Code Base
- 21 Jun 2020
- Medium
- Build: staging
- # 29732
- Diff
- PhilETaylor:patch-10
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Take it or leave it - Up to you.
Expected/Actual is "often subject of confusion".
New headings make it more clearer-er.
// @richard67
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository |
PhilETaylor
- comment
- 21 Jun 2020
I'd like to know @brianteeman 's opinion.
Dont worry I'm sure he will give it. haha
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-21 11:49:41 |
| Closed_By | ⇒ | PhilETaylor | |
| Labels |
Added:
?
|
||
richard67
- comment
- 21 Jun 2020
Why closing?
| Status | Closed | ⇒ | New |
| Closed_Date | 2020-06-21 11:49:41 | ⇒ | |
| Closed_By | PhilETaylor | ⇒ |
| Status | New | ⇒ | Pending |
PhilETaylor
- comment
- 21 Jun 2020
Changed as proposed:
### Actual result BEFORE applying this Pull Request
### Expected result AFTER applying this Pull Request
richard67
- comment
- 21 Jun 2020
I have tested this item
Makes sense to me and is an improvement in my opinion. Meaning of actual and expected result always was subject of confusion at least for new contributors.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29732.
Quy
- comment
- 21 Jun 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29732.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 21 Jun 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29732.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-21 14:46:39 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 21 Jun 2020
Seems clearer to me. Thanks!
I agree 100% with the motivation and the goal of this PR, but maybe the texts can be optimized?
I'd like to know @brianteeman 's opinion.
Maybe just drop the "Expected" so we just have "Result BEFORE applying this PR" and "Result AFTER applying this PR"?
Or maybe stay with "Actual" and "Expected" so we have "Actual result BEFORE applying this PR" and "Expected result AFTER applying this PR"?
And maybe in general use "Pull Request" instead of "PR"?