Feeling Lucky
?
?
[#29694] - [4.0] Refactor to return early, remove if depths and throw NotAllowed
- Fixed in Code Base
- 20 Jul 2020
- Medium
- Build: 4.0-dev
- # 29694
- Diff
- PhilETaylor:refactoranddeindent
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
While working in this area, noticed bad use of if statements so refactored it a little
This fixes nothing - it just improves code readability and implements best practices
Summary of Changes
Refactor to apply concept of "return early" by throwing NotAllowed exceptions if ACL fails
Testing Instructions
use com_contenthistory - nothing should be broken, ACL should correctly error, this time with NotAllowed exceptions
Expected result
Nothing broken
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content com_contenthistory |
| Labels |
Added:
?
|
||
PhilETaylor
- comment
- 8 Jul 2020
@richard67 Just needs one more human test (if you have time please) to get to RTC.
SharkyKZ
- comment
- 8 Jul 2020
Update doc blocks.
PhilETaylor
- comment
- 8 Jul 2020
Done.
alikon
- comment
- 8 Jul 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29694.
Quy
- comment
- 9 Jul 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29694.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 9 Jul 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29694.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-20 19:19:35 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
richard67
- comment
- 20 Jul 2020
Thanks!
I have tested this item✅ successfully on 28b8b81
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29694.