?
avatar PhilETaylor
PhilETaylor
18 Jun 2020

Steps to reproduce the issue

Not a bug - but on code review, this change should now be activated in Joomla 4 (according to the note) to increase the security of Joomla 4 and installing extensions.

When installing an extension in Joomla 4 with an invalid hash, installation should "abort" apparently

// The validation was not successful. Just a warning for now.
		// TODO: In Joomla 4 this will abort the installation
		if ($check === InstallerHelper::HASH_NOT_VALIDATED)
		{
			$app->enqueueMessage(Text::_('COM_INSTALLER_INSTALL_CHECKSUM_WRONG'), 'error');
		}

and

	// The validation was not successful for now just a warning.
		// TODO: In Joomla 4 this will abort the installation
		if ($result['check'] === false)
		{
			$message = Text::_('COM_JOOMLAUPDATE_VIEW_UPDATE_CHECKSUM_WRONG');
			$messageType = 'warning';

			try
			{
				Log::add($message, Log::INFO, 'Update');
			}
			catch (\RuntimeException $exception)
			{
				// Informational log only
			}
		}

Expected result

Joomla 4 should "abort the installation"

Actual result

Joomla 4 just shows a "a warning for now"

System information (as much as possible)

Additional comments

@SniperSister

avatar PhilETaylor PhilETaylor - open - 18 Jun 2020
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jun 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 18 Jun 2020
avatar PhilETaylor PhilETaylor - change - 18 Jun 2020
The description was changed
avatar PhilETaylor PhilETaylor - edited - 18 Jun 2020
avatar PhilETaylor PhilETaylor - change - 18 Jun 2020
The description was changed
avatar PhilETaylor PhilETaylor - edited - 18 Jun 2020
avatar PhilETaylor PhilETaylor - change - 18 Jun 2020
The description was changed
avatar PhilETaylor PhilETaylor - edited - 18 Jun 2020
avatar alikon
alikon - comment - 12 Jul 2020

@PhilETaylor can you give some feedback on #30076

avatar alikon
alikon - comment - 12 Jul 2020

@joomla/bug-squad please don't close this one till #30076 is a draft

avatar richard67
richard67 - comment - 12 Jul 2020

@alikon You mean "please don't close this one as long as #30076 is a draft", or in other words "please don't close this one till #30076 is not a draft anymore"?

avatar alikon
alikon - comment - 12 Jul 2020

the 1st ;)

please don't close this one as long as #30076 is a draft

avatar richard67
richard67 - comment - 12 Jul 2020

Both of my alternatives mean the same, but the opposite to what you wrote.

avatar alikon
alikon - comment - 12 Jul 2020

grr damned english

avatar richard67
richard67 - comment - 12 Jul 2020

Chinese would be harder ;-)

avatar alikon
alikon - comment - 13 Jul 2020

let's close this one as #30076 is no more a draft pr

avatar alikon alikon - change - 13 Jul 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-07-13 16:51:24
Closed_By alikon
avatar alikon alikon - close - 13 Jul 2020

Add a Comment

Login with GitHub to post a comment