? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
18 Jun 2020

Pull Request for part of Issue #29654 and a

Summary of Changes

Fix php notice when no version_id specified in faked/truncated url

Testing Instructions

Joomla 4
apply #29692
go to

http://127.0.0.1/administrator/index.php?option=com_contenthistory&view=preview&layout=preview&tmpl=component&version_id=

Expected result

No PHP notice, no comparison

After PR should be

Screenshot 2020-06-18 at 19 12 06

Actual result before PR

Screenshot 2020-06-18 at 19 02 59

Documentation Changes Required

none

avatar PhilETaylor PhilETaylor - open - 18 Jun 2020
avatar PhilETaylor PhilETaylor - change - 18 Jun 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jun 2020
Category Administration com_content com_contenthistory
avatar PhilETaylor PhilETaylor - change - 18 Jun 2020
Title
Fix php notice when no version_id specified
[4.0] Fix php notice when no version_id specified
avatar PhilETaylor PhilETaylor - edited - 18 Jun 2020
avatar PhilETaylor
PhilETaylor - comment - 18 Jun 2020

continuous-integration/drone/pr failing is nothing related to these changes

avatar PhilETaylor PhilETaylor - change - 18 Jun 2020
Labels Added: ?
avatar richard67 richard67 - test_item - 18 Jun 2020 - Tested successfully
avatar richard67
richard67 - comment - 18 Jun 2020

I have tested this item successfully on 25a6b56


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29693.

avatar Quy Quy - test_item - 18 Jun 2020 - Tested successfully
avatar Quy
Quy - comment - 18 Jun 2020

I have tested this item successfully on 25a6b56


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29693.

avatar Quy Quy - edited - 18 Jun 2020
avatar Quy Quy - change - 18 Jun 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 18 Jun 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29693.

avatar wilsonge wilsonge - change - 19 Jun 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-06-19 10:12:22
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 19 Jun 2020
avatar wilsonge wilsonge - merge - 19 Jun 2020
avatar wilsonge
wilsonge - comment - 19 Jun 2020

Thanks!

Add a Comment

Login with GitHub to post a comment