now gives

Notice: Undefined offset: 1 in /application/administrator/components/com_contenthistory/src/Helper/ContenthistoryHelper.php on line 184
The most recent request was denied because it had an invalid security token. Please refresh the page and try again.

Some of these in the middle of this search might need changing too ??

Those using JTable prefix are case insensitive. So they're fine for now.

ok cool well this fixes the reported issue, but still leaves that Notice: Undefined offset: 1 message above.

I have tested this item ✅ successfully on 896a8db

Confirm Actual Result before Patch.
@PhilETaylor With Patch: No message shown.

@ChristineWk

Try faking a url with no id on it:

http://127.0.0.1/administrator/index.php?option=com_contenthistory&view=preview&layout=preview&tmpl=component&version_id=

I have tested this item ✅ successfully on 896a8db

- Specific expected result for the issue tested successfully and preview of version was displayed.

• Confirmed that if URL @PhilETaylor prescribes is used, then there's still an offset error. However, why would someone want to manually fake a URL with no version ID value supplied - that would imply they know what the URL is trying to achieve, and that they would be expecting failure.

Not sure what the suggested solution should be there on that URL being used with no parameter? As it loads in a modal, should a direct access outside the modal trigger a die();?

I have tested this item ✅ successfully on 896a8db

- Specific expected result for the issue tested successfully and preview of version was displayed.

• Confirmed that if URL @PhilETaylor prescribes is used, then there's still an offset error. However, why would someone want to manually fake a URL with no version ID value supplied - that would imply they know what the URL is trying to achieve, and that they would be expecting failure.

Not sure what the suggested solution should be there on that URL being used with no parameter? As it loads in a modal, should a direct access outside the modal trigger a die();?

@particthistle The principle is that Joomla should NEVER output PHP Notices/Warnings to the screen. Joomla has been for years, developed with error_reporting set to max, and coded so that all routes, known and abused urls, can not produce uncaught and unhandled exceptions or notices. This has always been the case.

As it loads in a modal, should a direct access outside the modal trigger a die();?

Harder than it sounds ;-)

@PhilETaylor agree with the principle. And that it's hard than it sounds.

Code to suggest for this one escapes me at the second, and not just as it's 4am in Australia.

Notice fixed in #29693

I have tested this item ✅ successfully on 896a8db

3rd test is never bad ;-)

RTC

Thanks!