I have tested this item ? unsuccessfully on 269d0b7

Partially tested successfully.

Manager level user Success

• Manager doesn't have User management access
• Site Information module set to "Special"
• Number of users on the site not shown.

Administrator level user Issue Discovered

• Administrator has User management access
• Site Information module set to "Special"
• Number of users on the site not shown, but as the Administrator has User Management access, they should be able to see the number of users?

Line 108 looks to be overzealous:

if ($users && $user->authorise('core.PR an', 'com_users'))

Still working out Joomla function code... what's the 'core.PR an' permission do?

If a user hast not permission to manage users, he should not see the users information.

I do not agree with this assumption

I think it is perfectly valid that the site information module displays the count of users. It is only the link that needs to be removed

Changing it to core.manage at line 108 per @Quy suggestion resolved the issue I had with the PR test.

if ($users && $user->authorise('core.manage', 'com_users'))

@brianteeman I'm split on whether the non-user managers should be able to see the number of users.

Further to @brianteeman comment, changing 108-114 to the following would disable the link, but still display the number of users. It just doesn't format the number as it's no longer a link.

			if ($users)
			{
				$rows[$i]        = new \stdClass;
				$rows[$i]->title = Text::_('MOD_STATS_USERS');
				$rows[$i]->icon  = 'users';
				$rows[$i]->data  = $users;
				if ($user->authorise('core.manage', 'com_users'))
				    {
				    $rows[$i]->link  = Route::_('index.php?option=com_users');
				    }
				$i++;
			}

Thank you for testing and your opinion. I have fixed and changed as you prefer to remove only the link.

Thank you for testing and your opinion. I have fixed and changed as you prefer to remove only the link.

I have tested this item ✅ successfully on ac3f59f

I have tested this item ✅ successfully on ac3f59f

Revised version tested as expected.

Last 3 commits after @particthistle 's test have just been code style, so his test result is still valid. I'll add it back in the issue tracker so it is correctly counted.

@Quy After your test there have been changes which were not code style only. Could you test again? Thanks in advance.

I have tested this item ✅ successfully on 01c5665

RTC

@zero-24 GitHub still shows that there are changes requested. I think it's due to your past review, but it is solved meanwhile as far as I can see. Could you just review again so this display of requested changes disappears if all is ok?

Thanks!