?
avatar particthistle
particthistle
13 Jun 2020

Steps to reproduce the issue

"Save as copy" of default workflow brings up "Warning - Field required: Default" and doesn't make a copy.

  • Enable Workflows in Joomla 4 Beta 2 to be able to test this issue
  • Go to Content > Workflows
  • Edit the default workflow
  • Go to Save as Copy
    image

Expected result

You should have a second copy of the default workflow that you can then edit to your own requirements.

Actual result

Warning thrown and new copy is not created.
image

Additional comments

  • If you create a new workflow, and then Save as Copy to duplicate the new workflow, it makes a copy, so the issue is only affecting when you go to make a copy of the default workflow.
  • Discovered while testing #29263
avatar particthistle particthistle - open - 13 Jun 2020
avatar joomla-cms-bot joomla-cms-bot - change - 13 Jun 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 13 Jun 2020
avatar particthistle particthistle - change - 13 Jun 2020
The description was changed
avatar particthistle particthistle - edited - 13 Jun 2020
avatar chmst chmst - change - 14 Jun 2020
Status New Confirmed
avatar chmst
chmst - comment - 14 Jun 2020

Confirmed


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29597.

avatar particthistle
particthistle - comment - 27 Jun 2020

Additionally while testing PR for https://issues.joomla.org/tracker/joomla-cms/29573 I encountered a related variation - same code will most likely fix both.

I can set the second workflow as default while on the Workflows screen
29597-worfklowsdefault

When I edit the workflow, and then set it as default:

  • Setting the workflow to default and clicking Save a first time saves the workflow with the default setting set to Yes
  • Clicking Save again once the workflow is set as Default brings up the Warning: Field Required: Default
  • Clicking Save and Close one the workflow is set as Default also brings up the Warning: Field Required: Default and won't let you close the workflow due to the error.
  • When opening the workflow that is selected as default to modify it, you will get the Warning: Field Required: Default warning message on Save or Save and Close, so you can't customise the Basic Workflow while it's set as the default workflow, or any other workflow if it's set as the default workflow.
  • The only way to close the default workflow is to click Cancel.
    29597-worfklowssaveasdefault
avatar particthistle
particthistle - comment - 27 Jun 2020

@bembelimen you might be in the best position to address this issue.

avatar particthistle
particthistle - comment - 27 Jun 2020

Thanks @chmst - testing it now.

avatar particthistle
particthistle - comment - 27 Jun 2020

image

Additional issue discovered:
This issue was initially raised using Joomla 4.0 Beta 2 Dev where @benbelimen's final changes were then pulled into the final Joomla 4.0.0-beta1.

It appears "Save as Copy" is disabled in 4.0.0-beta1, so that needs to be also resolved.

avatar particthistle
particthistle - comment - 28 Jun 2020

Ignore previous comment.

This pull request fixes the Save2Copy being missing in 4.0.0-beta1
#29263

Applying nightly build restored the functionality.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29597.

avatar Quy Quy - change - 4 Jul 2020
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2020-07-04 15:16:26
Closed_By Quy
avatar Quy Quy - close - 4 Jul 2020

Add a Comment

Login with GitHub to post a comment