J4 Issue ?
avatar ceford
ceford
12 Jun 2020

Steps to reproduce the issue

Look at any Edit screen with multiple tabs on a narrow screen.

Expected result

Full screen width tabs usually have open/close arrows.

Actual result

screen shot 2020-06-12 at 11 56 53

System information (as much as possible)

Additional comments

Looked for but did not find anything similar.

avatar ceford ceford - open - 12 Jun 2020
avatar joomla-cms-bot joomla-cms-bot - labeled - 12 Jun 2020
avatar richard67 richard67 - change - 12 Jun 2020
Build Beta-2 Dev NB 4.0-dev
avatar richard67 richard67 - change - 12 Jun 2020
Labels Added: J4 Issue
avatar richard67 richard67 - labeled - 12 Jun 2020
avatar infograf768 infograf768 - change - 12 Jun 2020
Title
Should uitabs have open/close arrows on narrow screens?
[4.0] Should uitabs have open/close arrows on narrow screens?
avatar infograf768 infograf768 - edited - 12 Jun 2020
avatar infograf768
infograf768 - comment - 12 Jun 2020

Alas, I have also complained about that and received a will-not-do response from @dgrammatiko

avatar dgrammatiko
dgrammatiko - comment - 12 Jun 2020

and received a will-not-do response from @dgrammatiko

You received the will not do for 2 reasons:

  • I don't agree with the decision that tabs automatically convert to accordion
  • When I tried last time to fix the mess people weren't interested (to put it nicely)

So although I implemented the idea (it wasn't mine and I wasn't in favour) I cannot be blamed for it, I was just translating the requirements to code. Also just because you have different requirements now I cannot just simply jump in and implement them. It doesn't work like that...

avatar infograf768
infograf768 - comment - 12 Jun 2020

I was not the one having that requirement, as you may or may not know. In fact I never had any requirements for J4...
I am curious to know who had as this is one of J4 aspects which is totally counter-productive.
I discovered the issue when testing com_associations as it does not require a smaller screen.

avatar dgrammatiko
dgrammatiko - comment - 12 Jun 2020

I am curious to know who had as this is one of J4 aspects which is totally counter-productive.

The accessibility team, read their docs

avatar ceford
ceford - comment - 12 Jun 2020

I looked / searched for information on this topic but did not find anything. Is there a place where decisions are recorded? I am curious to know what the arguments were. I have been using Tabs that wrap and prefer that design.

avatar dgrammatiko
dgrammatiko - comment - 12 Jun 2020

@ceford unfortunately due to some reason the original docs are not available anymore (https://joomla.github.io/accessibility/#/) so the only resource there is joomla/accessibility#22

avatar richard67
richard67 - comment - 12 Jun 2020

I think there should be some arrows or +/- icons, however it is achieved. Just my 5 ct.

avatar dgrammatiko
dgrammatiko - comment - 12 Jun 2020

I think there should be some arrows or +/- icons, however it is achieved. Just my 5 ct.

It can be done with some css. No js code needed for this

avatar infograf768
infograf768 - comment - 12 Jun 2020

arrows are not the issue.
what is needed is what we get with bootstrap accordion + slide, so that we can close a slide.
uitabs only closes a slide when opening another which forces to scroll and scroll...

avatar dgrammatiko
dgrammatiko - comment - 12 Jun 2020

uitabs only closes a slide when opening another which forces to scroll and scroll

@infograf768 just add a return after https://github.com/joomla-projects/custom-elements/blob/4395d94226466041ac874dcbcfe9acb7b3c0e647/src/js/tab/tab.js#L202

So simple...

avatar ceford
ceford - comment - 13 Jun 2020

I think this is worth pursuing. As evidence I include screenshots in responsive design mode. Firstly from one of my Admin forms in j3, portrait mode:
image
And from the same form in J4, landscape mode:
image
In the latter it is not possible to see all of the Tabs at once and you have to scroll past a long form section to find the next tab. As a user experience - dreadful. And those wide blue bands - ugly!

So I am thinking custom css and/or javascript.

avatar infograf768
infograf768 - comment - 13 Jun 2020

@infograf768 just add a return after https://github.com/joomla-projects/custom-elements/blob/4395d94226466041ac874dcbcfe9acb7b3c0e647/src/js/tab/tab.js#L202

So simple...

@dgrammatiko
Not so simple. I'm afraid this is not enough.

        if (this.hasActive) {
          this.hideCurrent();
          return;
        }

It lets close the open slide indeed by clicking on it but then it is impossible to open any slide, including the one just closed.

avatar dgrammatiko
dgrammatiko - comment - 13 Jun 2020

It lets close the open slide indeed by clicking on it

That's what you've asked for

but then it is impossible to open any slide, including the one just closed.

So it needs to be conditional only if the the clicked link is the current one and you're in the accordion mode...

avatar infograf768
infograf768 - comment - 13 Jun 2020

So it needs to be conditional only if the the clicked link is the current one and you're in the accordion mode...

@dgrammatiko
Not sure what you mean exactly. I am no js expert.
What we need is a behavior similar to bootstrap accordeon/slide

I.e. clicking on the slide title lets open when closed and close when opened.
Can you provide the full patch?

avatar dgrammatiko
dgrammatiko - comment - 13 Jun 2020

Sorry no, no spare time

avatar infograf768
infograf768 - comment - 14 Jun 2020

@Fedik
Could you please have a look?

avatar Fedik
Fedik - comment - 14 Jun 2020

to be honest I not very like current tabs/accordion thing :)
I cannot promise much,
but I agree it an issue, not arrow/plus icon, but toggling

avatar jwaisner jwaisner - change - 16 Jun 2020
Status New Confirmed
avatar Fedik
Fedik - comment - 28 Jun 2020

@infograf768 please try the changes from that pull joomla-projects/custom-elements#141
that should toggle an accordion

avatar brianteeman
brianteeman - comment - 21 Dec 2020

@infograf768 did you test the proposed change from @Fedik to address your change request

avatar infograf768
infograf768 - comment - 22 Dec 2020

No. Will look.

avatar infograf768
infograf768 - comment - 22 Dec 2020
avatar infograf768
infograf768 - comment - 22 Dec 2020

To test:
Set debug system and replace file
/media/vendor/joomla-custom-elements/js/joomla-tab.js
by this one, decompressed.

joomla-tab.js.zip

avatar infograf768 infograf768 - change - 24 Dec 2020
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2020-12-24 10:16:41
Closed_By infograf768
avatar infograf768
infograf768 - comment - 24 Dec 2020

Closing as toggling now works correctly in 4.0-dev. The matter of up/down arrow looks epiphenomenic.

avatar infograf768 infograf768 - close - 24 Dec 2020

Add a Comment

Login with GitHub to post a comment