[#29579] - [4.0] Remove margin between accordion slides
- Fixed in Code Base
- 12 Jun 2020
- Medium
- Build: 4.0-dev
- # 29579
- Diff
- SharkyKZ:j4/markup/accordion
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Fixes #29311.
Summary of Changes
Removes margin between Bootstrap accordion slides.
Testing Instructions
Edit a module in frontend.
Expected result
Looks OK.
Actual result
Gap between slides and first slide is missing the bottom border:
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
| Category | Libraries | ⇒ | Front End com_config Libraries |
I can evidently solve it by adding the mb-2 class to the div enclosing this template but I wonder if this PR is the correct solution.
<div class="col-md-12 mb-2">
<?php echo $this->loadTemplate('legend'); ?>
</div>
I have tested this item
First bottom margin present - but no gaps between unopened tabs, is that intended.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29579.
I have tested this item
I guess will just have to modify my component.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29579.
| Status | Pending | ⇒ | Ready to Commit |
rtc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29579.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-12 11:00:55 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
Thanks all!
@ceford Yes, that's expected.
@infograf768 you can also pass mb-2 class to HTMLHelper::_('bootstrap.addSlide').
This PR is fine in that it fixes the default styling. Before patch, this looked fine in Atum because it has custom CSS but not in Cassiopeia or in any stock Bootstrap template.
I have a B/C problem here with com_localise after this patch.
I do use the below code and display a table in the slide
Then I have another accordeon + slide.
I lose the mb-2 margin
Before this PR
After this PR
