Feeling Lucky
?
?
[#29578] - [4.0] Correct link preload header
- Fixed in Code Base
- 12 Jun 2020
- Medium
- Build: 4.0-dev
- # 29578
- Diff
- SharkyKZ:j4/fix/preload
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #29288.
Summary of Changes
Corrects link preload header.
Testing Instructions
Code review.
Or view any frontend page. Inspect headers, specifically Link header.
Expected result
Link: <https://fonts.googleapis.com/css?family=Fira+Sans:400>; rel="preload"; as="style"
Actual result
Link: <https://fonts.googleapis.com/css?family=Fira+Sans:400>; rel="preload"; as="stylesheet"
Which generates an error:
<link rel=preload> must have a valid `as` value
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
bonzani
- comment
- 12 Jun 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29578.
ChristineWk
- comment
- 12 Jun 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29578.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
SharkyKZ
- comment
- 12 Jun 2020
RTC.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29578.
SharkyKZ
- comment
- 12 Jun 2020
RTC.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29578.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-12 10:19:44 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
richard67
- comment
- 12 Jun 2020
Thanks all!
I have tested this item✅ successfully on be2c53f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29578.